Closed jlojosnegros closed 2 years ago
Totals | |
---|---|
Change from base Build 2558: | 0.0% |
Covered Lines: | 1644 |
Relevant Lines: | 2719 |
/cc @fromanirh @marioferh
nice! how was this tested?
I ran it against a cluster Shereen kindly lent to me with NRO already installed. I have also ran it against a "kind" cluster after running e2e tests but without cleaning up so it had crds instances
nice! how was this tested?
I ran it against a cluster Shereen kindly lent to me with NRO already installed. I have also ran it against a "kind" cluster after running e2e tests but without cleaning up so it had crds instances
[EDIT already answered, moving on the next subject] ok, so we don't have e2e coverage.
I'm trying to think how a e2e test could look like for this change. We should probably have the test running in the NROP CI (not PAO's), and should run like nightly or weekly - since it cannot run on PR changes - different repo.
[EDIT] like, for GH actions: https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#schedule maybe we can do something like this for prow
thanks, LGTM. I'll verify ASAP, but let's file a issue to track lack of e2e tests, so we can merge (and then add the e2e tests).
Issue created #920
thanks, LGTM. I'll verify ASAP, but let's file a issue to track lack of e2e tests, so we can merge (and then add the e2e tests).
Issue created #920
I think it's more fitting for the numaresources operator, though. We're somehow halfway, but most of the resources, the pieces and the infra are more readily available on NRO CI than setting up a completely alien flow in the PAO CI.
/override ci/prow/e2e-gcp /override ci/prow/e2e-gcp-operator-upgrade still haven't had the chance to verify
@fromanirh: Overrode contexts on behalf of fromanirh: ci/prow/e2e-gcp, ci/prow/e2e-gcp-operator-upgrade
/lgtm /approve verified!
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: fromanirh, jlojosnegros
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Need to gather data regarding new NUMA resources operator but currently must-gather does not collect this data. Different approachs were discussed but in the end we have decided to collect NRO data here to avoid creating new must-gather images.