search

openshift-kni / performance-addon-operators

Operators related to optimizing OpenShift clusters for applications sensitive to cpu and network latency
Apache License 2.0
45 stars 60 forks source link

deps: pin pcidb to 1.0.0 #924

Closed ffromani closed 2 years ago

ffromani commented 2 years ago

Up until version 1.0.0 excluded, pcidb tried to download from network the pcidb if that was missing, which was the case for container images which did not install, directly or indirectly, the hwdata package.

The conditions to trigger a network download are actually non trivial - the code needed to require PCI listing functionality, which are unlikely here.

Nevertheless, the version 1.0.0 of pcidb switched the default to a saner "do not attempt network fetch unless explicitely asked for" while being otherwise backward compatible (API-wise), so let's consume this dependency and let's get rid of this potential issue entirely.

Signed-off-by: Francesco Romani fromani@redhat.com

coveralls commented 2 years ago

Pull Request Test Coverage Report for Build 2571

Totals Coverage Status
Change from base Build 2565: 0.0%
Covered Lines: 1644
Relevant Lines: 2719
💛 - Coveralls
openshift-ci[bot] commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fromanirh, MarSik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift-kni/performance-addon-operators/blob/master/OWNERS)~~ [MarSik,fromanirh] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
ffromani commented 2 years ago

/override ci/prow/e2e-gcp /override ci/prow/e2e-gcp-operator-upgrade

openshift-ci[bot] commented 2 years ago

@fromanirh: Overrode contexts on behalf of fromanirh: ci/prow/e2e-gcp, ci/prow/e2e-gcp-operator-upgrade

In response to [this](https://github.com/openshift-kni/performance-addon-operators/pull/924#issuecomment-1196357477): >/override ci/prow/e2e-gcp >/override ci/prow/e2e-gcp-operator-upgrade Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.