openshift-kni / performance-addon-operators

Operators related to optimizing OpenShift clusters for applications sensitive to cpu and network latency
Apache License 2.0
45 stars 60 forks source link

gh actions: add workflow to build tool #927

Closed shajmakh closed 2 years ago

shajmakh commented 2 years ago

Add new workflow to build and release binary for tools/hugepages-machineconfig-generator to enable using it externally.

coveralls commented 2 years ago

Pull Request Test Coverage Report for Build 2579


Totals Coverage Status
Change from base Build 2565: 0.0%
Covered Lines: 1644
Relevant Lines: 2719

💛 - Coveralls
shajmakh commented 2 years ago

need to add a new tag from master to enable this workflow to run correctly and provide releases with the tool binary.

shajmakh commented 2 years ago

/retest-required

ffromani commented 2 years ago

/retest-required

it is good to have a full green run, but for this specific PR we can safely override failing lines. Adding github actions config can't possibly break any production flow (or test code)

shajmakh commented 2 years ago

/override ci/prow/e2e-gcp-operator-upgrade /override ci/prow/e2e-gcp

openshift-ci[bot] commented 2 years ago

@shajmakh: shajmakh unauthorized: /override is restricted to Repo administrators, approvers in top level OWNERS file, and the following github teams:.

In response to [this](https://github.com/openshift-kni/performance-addon-operators/pull/927#issuecomment-1192351230): >/override ci/prow/e2e-gcp-operator-upgrade >/override ci/prow/e2e-gcp Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
ffromani commented 2 years ago

/override ci/prow/e2e-gcp-operator-upgrade /override ci/prow/e2e-gcp

don't worry, I can override once we reach consensus :) we only need more LGTMs

swatisehgal commented 2 years ago

/lgtm

ffromani commented 2 years ago

/override ci/prow/e2e-gcp-operator-upgrade /override ci/prow/e2e-gcp

openshift-ci[bot] commented 2 years ago

@fromanirh: Overrode contexts on behalf of fromanirh: ci/prow/e2e-gcp, ci/prow/e2e-gcp-operator-upgrade

In response to [this](https://github.com/openshift-kni/performance-addon-operators/pull/927#issuecomment-1192532520): >/override ci/prow/e2e-gcp-operator-upgrade >/override ci/prow/e2e-gcp Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
ffromani commented 2 years ago

/approve

openshift-ci[bot] commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fromanirh, shajmakh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift-kni/performance-addon-operators/blob/master/OWNERS)~~ [fromanirh] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
ffromani commented 2 years ago

/hold cancel