openshift-kni / performance-addon-operators

Operators related to optimizing OpenShift clusters for applications sensitive to cpu and network latency
Apache License 2.0
45 stars 60 forks source link

e2e: latency: skip the tests earlier in the suite #930

Closed shajmakh closed 2 years ago

shajmakh commented 2 years ago

This suite works properly only if the test executable exists. Currently each test checks for the existence of this common executable. The suite performs some setup steps that are relevant for this set of tests, without considering whether the file exists or not. To avoid extra unneeded execution time, skip the suite at an early stage if the executable file does not exist.

openshift-ci[bot] commented 2 years ago

@shajmakh: No Bugzilla bug is referenced in the title of this pull request. To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to [this](https://github.com/openshift-kni/performance-addon-operators/pull/930): >e2e: latency: skip the tests earlier in the suite Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
openshift-ci[bot] commented 2 years ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: shajmakh Once this PR has been reviewed and has the lgtm label, please assign tal-or for approval by writing /assign @tal-or in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/openshift-kni/performance-addon-operators/blob/release-4.10/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
coveralls commented 2 years ago

Pull Request Test Coverage Report for Build 2583


Totals Coverage Status
Change from base Build 2567: 0.0%
Covered Lines: 1592
Relevant Lines: 2630

💛 - Coveralls
shajmakh commented 2 years ago

/hold do not merge until 4.11 batch is merged: https://github.com/openshift/cluster-node-tuning-operator/pull/429

shajmakh commented 2 years ago

following the conversation here and on the team channel, using defere() will not always clean up the env in case of interruptions and/or assertion failures, thus closing this pr in favor of #938 that introduce another alternative skipping method while preserving the before/afterSuites