Closed shajmakh closed 2 years ago
@shajmakh: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh
.
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: shajmakh
Once this PR has been reviewed and has the lgtm label, please assign tal-or for approval by writing /assign @tal-or
in a comment. For more information see:The Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
Totals | |
---|---|
Change from base Build 2567: | 0.0% |
Covered Lines: | 1592 |
Relevant Lines: | 2630 |
/hold do not merge until 4.11 batch is merged: https://github.com/openshift/cluster-node-tuning-operator/pull/429
following the conversation here and on the team channel, using defere() will not always clean up the env in case of interruptions and/or assertion failures, thus closing this pr in favor of #938 that introduce another alternative skipping method while preserving the before/afterSuites
This suite works properly only if the test executable exists. Currently each test checks for the existence of this common executable. The suite performs some setup steps that are relevant for this set of tests, without considering whether the file exists or not. To avoid extra unneeded execution time, skip the suite at an early stage if the executable file does not exist.