search

openshift-kni / performance-addon-operators

Operators related to optimizing OpenShift clusters for applications sensitive to cpu and network latency
Apache License 2.0
46 stars 60 forks source link

"Add imagePullPolicy verification test" #934

Closed shaior closed 2 years ago

shaior commented 2 years ago

Automates https://bugzilla.redhat.com/show_bug.cgi?id=2055019

openshift-ci[bot] commented 2 years ago

@shaior: This pull request references Bugzilla bug 2055019, which is invalid:

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to [this](https://github.com/openshift-kni/performance-addon-operators/pull/934): >Bug 2055019: Add imagePullPolicy verification Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
openshift-ci[bot] commented 2 years ago

Hi @shaior. Thanks for your PR.

I'm waiting for a openshift-kni member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
coveralls commented 2 years ago

Pull Request Test Coverage Report for Build 2590

Totals Coverage Status
Change from base Build 2567: 0.0%
Covered Lines: 1592
Relevant Lines: 2630
💛 - Coveralls
ffromani commented 2 years ago

/ok-to-test

ffromani commented 2 years ago

/approve /lgtm

openshift-ci[bot] commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fromanirh, shaior

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift-kni/performance-addon-operators/blob/release-4.10/OWNERS)~~ [fromanirh] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
ffromani commented 2 years ago

/hold

ffromani commented 2 years ago

wait a sec: are we fixing this bug first on branch 4.10? if so, why?

mrniranjan commented 2 years ago

@fromanirh because this bug affects 4.10 and below only . Do we want to fix it in master. I was under the impression that master branch is mostly backports of NTO

ffromani commented 2 years ago

@fromanirh because this bug affects 4.10 and below only . Do we want to fix it in master. I was under the impression that master branch is mostly backports of NTO

ok, it makes sense to me to have fixes only for PAO as independent operator.

ffromani commented 2 years ago

/hold cancel

shaior commented 2 years ago

/cherry-pick release-4.9

openshift-cherrypick-robot commented 2 years ago

@shaior: only openshift-kni org members may request cherry-picks. You can still do the cherry-pick manually.

In response to [this](https://github.com/openshift-kni/performance-addon-operators/pull/934#issuecomment-1219362936): >/cherry-pick release-4.9 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
shajmakh commented 2 years ago

/cherry-pick release-4.9

openshift-cherrypick-robot commented 2 years ago

@shajmakh: once the present PR merges, I will cherry-pick it on top of release-4.9 in a new PR and assign it to you.

In response to [this](https://github.com/openshift-kni/performance-addon-operators/pull/934#issuecomment-1219363894): >/cherry-pick release-4.9 > > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
shajmakh commented 2 years ago

/retitle "Add imagePullPolicy verification"

openshift-ci[bot] commented 2 years ago

@shaior: No Bugzilla bug is referenced in the title of this pull request. To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to [this](https://github.com/openshift-kni/performance-addon-operators/pull/934): >"Add imagePullPolicy verification" Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
shajmakh commented 2 years ago

/retitle "Add imagePullPolicy verification test"

openshift-ci[bot] commented 2 years ago

@shaior: No Bugzilla bug is referenced in the title of this pull request. To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to [this](https://github.com/openshift-kni/performance-addon-operators/pull/934): >"Add imagePullPolicy verification test" Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
openshift-cherrypick-robot commented 2 years ago

@shajmakh: new pull request created: #936

In response to [this](https://github.com/openshift-kni/performance-addon-operators/pull/934#issuecomment-1219363894): >/cherry-pick release-4.9 > > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.