search

openshift-kni / performance-addon-operators

Operators related to optimizing OpenShift clusters for applications sensitive to cpu and network latency
Apache License 2.0
46 stars 60 forks source link

Add ethtool -k and ethtool -l to must gather collected data #935

Closed marioferh closed 2 years ago

marioferh commented 2 years ago

Add ethtool -k and ethtool -l to must gather collected data Save in ethtool_features and ethtool_channels files

Signed-off-by: Mario Fernandez mariofer@redhat.com

coveralls commented 2 years ago

Pull Request Test Coverage Report for Build 2591

Totals Coverage Status
Change from base Build 2581: 0.0%
Covered Lines: 1644
Relevant Lines: 2719
💛 - Coveralls
yanirq commented 2 years ago

do we have a test for that ? or what is tested in a different method ?

marioferh commented 2 years ago

do we have a test for that ? or what is tested in a different method ?

the tests are in NTO: https://github.com/openshift/cluster-node-tuning-operator/pull/365/files

But it is needed to upload new data. I want to do a new test with real data generated in the cluster, when that PR will be merged I will add the test for these files also.

marioferh commented 2 years ago

After this one we can add test in NTO https://github.com/openshift/cluster-node-tuning-operator/pull/442

marioferh commented 2 years ago

Test in: https://github.com/openshift/cluster-node-tuning-operator/pull/450

ffromani commented 2 years ago

/override ci/prow/e2e-gcp

openshift-ci[bot] commented 2 years ago

@fromanirh: Overrode contexts on behalf of fromanirh: ci/prow/e2e-gcp

In response to [this](https://github.com/openshift-kni/performance-addon-operators/pull/935#issuecomment-1273266485): >/override ci/prow/e2e-gcp Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
ffromani commented 2 years ago

/override ci/prow/e2e-gcp-operator-upgrade

openshift-ci[bot] commented 2 years ago

@fromanirh: Overrode contexts on behalf of fromanirh: ci/prow/e2e-gcp-operator-upgrade

In response to [this](https://github.com/openshift-kni/performance-addon-operators/pull/935#issuecomment-1273266767): >/override ci/prow/e2e-gcp-operator-upgrade Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
ffromani commented 2 years ago

/lgtm /approve

openshift-ci[bot] commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fromanirh, marioferh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift-kni/performance-addon-operators/blob/master/OWNERS)~~ [fromanirh] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment