openshift-kni / performance-addon-operators

Operators related to optimizing OpenShift clusters for applications sensitive to cpu and network latency
Apache License 2.0
45 stars 60 forks source link

must-gather:podinfo: Add RBAC elements to list pods #937

Closed jlojosnegros closed 2 years ago

jlojosnegros commented 2 years ago

podinfo command need to list all pods in all namespaces scheduled to a certain node. In order to do that it needs to have the proper permissions.

Add a new ClusterRole,adding read permisions over pods in all namespaces, and a ClusterRoleBinding to bind those persmissions to the ServiceAccount used by the must-gather daemonset pods.

podinfo in pao: #907 podinfo command: openshift-kni/debug-tools#64

coveralls commented 2 years ago

Pull Request Test Coverage Report for Build 2597


Totals Coverage Status
Change from base Build 2581: 0.0%
Covered Lines: 1644
Relevant Lines: 2719

💛 - Coveralls
openshift-ci[bot] commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fromanirh, jlojosnegros

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift-kni/performance-addon-operators/blob/master/OWNERS)~~ [fromanirh] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
jlojosnegros commented 2 years ago

@jlojosnegros: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command ci/prow/e2e-gcp-operator-upgrade ed616e4 link false /test e2e-gcp-operator-upgrade ci/prow/e2e-gcp ed616e4 link false /test e2e-gcp Full PR test history. Your PR dashboard.

I think we still need to override these two test lanes...

ffromani commented 2 years ago

@jlojosnegros: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests: Test name Commit Details Required Rerun command ci/prow/e2e-gcp-operator-upgrade ed616e4 link false /test e2e-gcp-operator-upgrade ci/prow/e2e-gcp ed616e4 link false /test e2e-gcp Full PR test history. Your PR dashboard.

I think we still need to override these two test lanes...

yeah, it seems we didn't make so much progress in this area lately. And these two lanes don't check this flow anyway.

ffromani commented 2 years ago

/override ci/prow/e2e-gcp-operator-upgrade

openshift-ci[bot] commented 2 years ago

@fromanirh: Overrode contexts on behalf of fromanirh: ci/prow/e2e-gcp-operator-upgrade

In response to [this](https://github.com/openshift-kni/performance-addon-operators/pull/937#issuecomment-1220338500): >/override ci/prow/e2e-gcp-operator-upgrade Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
ffromani commented 2 years ago

/override ci/prow/e2e-gcp

openshift-ci[bot] commented 2 years ago

@fromanirh: Overrode contexts on behalf of fromanirh: ci/prow/e2e-gcp

In response to [this](https://github.com/openshift-kni/performance-addon-operators/pull/937#issuecomment-1220338648): >/override ci/prow/e2e-gcp Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
jlojosnegros commented 2 years ago

/cherry-pick release-4.10

As #907 has been only cherry-picked to 4.10 this change need to be also cherry-picked to the same release.

openshift-cherrypick-robot commented 2 years ago

@jlojosnegros: new pull request created: #944

In response to [this](https://github.com/openshift-kni/performance-addon-operators/pull/937#issuecomment-1232602151): >/cherry-pick release-4.10 > >As #907 has been only cherry-picked to 4.10 this change need to be also cherry-picked to the same release. Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.