search

openshift-kni / performance-addon-operators

Operators related to optimizing OpenShift clusters for applications sensitive to cpu and network latency
Apache License 2.0
46 stars 60 forks source link

hack: skip tests under 5_latency_testing #938

Closed shajmakh closed 2 years ago

shajmakh commented 2 years ago

The tests in 5_latency_testing should run only on-demand and by using different make target with relevant dependencies. Skip this package using ginkgo skipPackage flag. additionally to some cleanup and fixes, see commits for more details.

openshift-ci[bot] commented 2 years ago

@shajmakh: No Bugzilla bug is referenced in the title of this pull request. To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to [this](https://github.com/openshift-kni/performance-addon-operators/pull/938): >e2e: latency: skip the tests earlier in the suite Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
coveralls commented 2 years ago

Pull Request Test Coverage Report for Build 2607

Totals Coverage Status
Change from base Build 2592: 0.0%
Covered Lines: 1592
Relevant Lines: 2630
💛 - Coveralls
openshift-ci[bot] commented 2 years ago

@shajmakh: No Bugzilla bug is referenced in the title of this pull request. To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to [this](https://github.com/openshift-kni/performance-addon-operators/pull/938): >WIP: e2e: latency: skip the tests earlier in the suite Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
shajmakh commented 2 years ago

/cc @MarSik @Tal-or

openshift-ci[bot] commented 2 years ago

@shajmakh: No Bugzilla bug is referenced in the title of this pull request. To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to [this](https://github.com/openshift-kni/performance-addon-operators/pull/938): > e2e: latency: skip the tests earlier in the suite Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
openshift-ci[bot] commented 2 years ago

@shajmakh: No Bugzilla bug is referenced in the title of this pull request. To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to [this](https://github.com/openshift-kni/performance-addon-operators/pull/938): > e2e: latency: skip the tests earlier in the suite Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
openshift-ci[bot] commented 2 years ago

@shajmakh: No Bugzilla bug is referenced in the title of this pull request. To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to [this](https://github.com/openshift-kni/performance-addon-operators/pull/938): >hack: skip tests under 5_latency_testing Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
openshift-ci[bot] commented 2 years ago

@shajmakh: No Bugzilla bug is referenced in the title of this pull request. To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to [this](https://github.com/openshift-kni/performance-addon-operators/pull/938): >hack: skip tests under 5_latency_testing Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
openshift-ci[bot] commented 2 years ago

@shajmakh: No Bugzilla bug is referenced in the title of this pull request. To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to [this](https://github.com/openshift-kni/performance-addon-operators/pull/938): >hack: skip tests under 5_latency_testing Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
shajmakh commented 2 years ago

Following the offline conversation with @Tal-or we agreed to skip the suite ahead from the functests-only target and fail the suite in case the binary is not found.

shajmakh commented 2 years ago

/retest

shajmakh commented 2 years ago

/test e2e-gcp-operator-upgrade

Tal-or commented 2 years ago

/lgtm /approve Thanks!

openshift-ci[bot] commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: shajmakh, Tal-or

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift-kni/performance-addon-operators/blob/release-4.10/OWNERS)~~ [Tal-or] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment