openshift-kni / performance-addon-operators

Operators related to optimizing OpenShift clusters for applications sensitive to cpu and network latency
Apache License 2.0
46 stars 60 forks source link

must-gather: numaresources: Avoid error messages when NRO is not installed #939

Closed jlojosnegros closed 2 years ago

jlojosnegros commented 2 years ago

must-gather is trying to get NRO related information (CRDs, and namespaced artifacts) no matter what and so, when NRO is not installed in the cluster some nasty error messages appear because those elements are not found.

These are not errors but to avoid missleading the users it is better to avoid them by not gathering the NRO information if we cannot detect the NRO namespace. A small message appears in console in this case.

jlojosnegros commented 2 years ago

/cc @shajmakh /hold till fully tested

coveralls commented 2 years ago

Pull Request Test Coverage Report for Build 2609


Totals Coverage Status
Change from base Build 2598: 0.0%
Covered Lines: 1644
Relevant Lines: 2719

💛 - Coveralls
shajmakh commented 2 years ago

Thanks! /lgtm

jlojosnegros commented 2 years ago

/unhold

jlojosnegros commented 2 years ago

I think the two failing ci lanes need to be overridden

ffromani commented 2 years ago

/override ci/prow/e2e-gcp

openshift-ci[bot] commented 2 years ago

@fromanirh: Overrode contexts on behalf of fromanirh: ci/prow/e2e-gcp

In response to [this](https://github.com/openshift-kni/performance-addon-operators/pull/939#issuecomment-1238150553): >/override ci/prow/e2e-gcp > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
ffromani commented 2 years ago

/override ci/prow/e2e-gcp-operator-upgrade

ffromani commented 2 years ago

/approve

openshift-ci[bot] commented 2 years ago

@fromanirh: Overrode contexts on behalf of fromanirh: ci/prow/e2e-gcp-operator-upgrade

In response to [this](https://github.com/openshift-kni/performance-addon-operators/pull/939#issuecomment-1238150757): >/override ci/prow/e2e-gcp-operator-upgrade Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
openshift-ci[bot] commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fromanirh, jlojosnegros

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift-kni/performance-addon-operators/blob/master/OWNERS)~~ [fromanirh] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment