openshift-kni / performance-addon-operators

Operators related to optimizing OpenShift clusters for applications sensitive to cpu and network latency
Apache License 2.0
46 stars 60 forks source link

Add must_gather tests #943

Open marioferh opened 2 years ago

marioferh commented 2 years ago

Add must_gather tests, manual cherry-pick from NTO https://github.com/openshift/cluster-node-tuning-operator/pull/442

Signed-off-by: Mario Fernandez mariofer@redhat.com

openshift-ci[bot] commented 2 years ago

@marioferh: No Bugzilla bug is referenced in the title of this pull request. To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to [this](https://github.com/openshift-kni/performance-addon-operators/pull/943): >Add must_gather tests Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
coveralls commented 2 years ago

Pull Request Test Coverage Report for Build 2640


Totals Coverage Status
Change from base Build 2631: 0.0%
Covered Lines: 1592
Relevant Lines: 2630

💛 - Coveralls
marioferh commented 2 years ago

/test e2e-gcp-operator-upgrade

yanirq commented 2 years ago

if this is still needed for master we will need to create a must gather test lane instead of e2e-gcp

marioferh commented 2 years ago

It is needed, but also good for future PR's.

yanirq commented 2 years ago

@marioferh we actually need this cherry pick for 4.11 and master branch here dont we ? At least until we move must gather to a different repo

openshift-ci[bot] commented 2 years ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: marioferh Once this PR has been reviewed and has the lgtm label, please assign fromanirh for approval by writing /assign @fromanirh in a comment. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/openshift-kni/performance-addon-operators/blob/release-4.10/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci[bot] commented 2 years ago

@marioferh: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gcp 0397579b7baa0b435851b8bdbf8caf0513ef2f8e link true /test e2e-gcp
ci/prow/e2e-gcp-operator-upgrade 0397579b7baa0b435851b8bdbf8caf0513ef2f8e link true /test e2e-gcp-operator-upgrade

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
ffromani commented 1 year ago

scratch my comments, I didn't notice this is a cherry pick.