search

openshift-kni / performance-addon-operators

Operators related to optimizing OpenShift clusters for applications sensitive to cpu and network latency
Apache License 2.0
46 stars 60 forks source link

Add test_id to imagePullPolicy should be ifNotPresent tc #945

Closed shaior closed 2 years ago

shaior commented 2 years ago

Add missing test id to the test case that verifies that imagePullPolicy of the operator pod is ifNotPresent, this will enable clear test result reporting.

openshift-ci[bot] commented 2 years ago

@shaior: No Bugzilla bug is referenced in the title of this pull request. To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to [this](https://github.com/openshift-kni/performance-addon-operators/pull/945): >Add test_id to imagePullPolicy should be ifNotPresent tc Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
openshift-ci[bot] commented 2 years ago

Hi @shaior. Thanks for your PR.

I'm waiting for a openshift-kni member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
coveralls commented 2 years ago

Pull Request Test Coverage Report for Build 2620

Totals Coverage Status
Change from base Build 2617: 0.0%
Covered Lines: 1592
Relevant Lines: 2630
💛 - Coveralls
shaior commented 2 years ago

/cherry-pick release-4.9

openshift-cherrypick-robot commented 2 years ago

@shaior: only openshift-kni org members may request cherry-picks. You can still do the cherry-pick manually.

In response to [this](https://github.com/openshift-kni/performance-addon-operators/pull/945#issuecomment-1244988304): >/cherry-pick release-4.9 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
shaior commented 2 years ago

/cherry-pick release-4.9

openshift-cherrypick-robot commented 2 years ago

@shaior: once the present PR merges, I will cherry-pick it on top of release-4.9 in a new PR and assign it to you.

In response to [this](https://github.com/openshift-kni/performance-addon-operators/pull/945#issuecomment-1245036432): >/cherry-pick release-4.9 > > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
ffromani commented 2 years ago

/ok-to-test

openshift-ci[bot] commented 2 years ago

@shaior: No Bugzilla bug is referenced in the title of this pull request. To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to [this](https://github.com/openshift-kni/performance-addon-operators/pull/945): >Add test_id to imagePullPolicy should be ifNotPresent tc Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
shajmakh commented 2 years ago

/cherry-pick release-4.9

openshift-cherrypick-robot commented 2 years ago

@shajmakh: once the present PR merges, I will cherry-pick it on top of release-4.9 in a new PR and assign it to you.

In response to [this](https://github.com/openshift-kni/performance-addon-operators/pull/945#issuecomment-1245080208): >/cherry-pick release-4.9 > > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
ffromani commented 2 years ago

/lgtm /approve

openshift-ci[bot] commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fromanirh, shaior

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift-kni/performance-addon-operators/blob/release-4.10/OWNERS)~~ [fromanirh] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
shaior commented 2 years ago

/retest

ffromani commented 2 years ago

/override ci/prow/e2e-gcp

openshift-ci[bot] commented 2 years ago

@fromanirh: Overrode contexts on behalf of fromanirh: ci/prow/e2e-gcp

In response to [this](https://github.com/openshift-kni/performance-addon-operators/pull/945#issuecomment-1245302002): >/override ci/prow/e2e-gcp Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
ffromani commented 2 years ago

/override ci/prow/e2e-gcp-operator-upgrade

openshift-ci[bot] commented 2 years ago

@fromanirh: Overrode contexts on behalf of fromanirh: ci/prow/e2e-gcp-operator-upgrade

In response to [this](https://github.com/openshift-kni/performance-addon-operators/pull/945#issuecomment-1245302197): >/override ci/prow/e2e-gcp-operator-upgrade Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
openshift-cherrypick-robot commented 2 years ago

@shajmakh: new pull request created: #946

In response to [this](https://github.com/openshift-kni/performance-addon-operators/pull/945#issuecomment-1245080208): >/cherry-pick release-4.9 > > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.