search

openshift-kni / performance-addon-operators

Operators related to optimizing OpenShift clusters for applications sensitive to cpu and network latency
Apache License 2.0
46 stars 60 forks source link

[release-4.10] [manual] OCPBUGS-4033: set RPS for veth on host level only #953

Closed Tal-or closed 1 year ago

Tal-or commented 1 year ago

RPS handling on pod container level using crio-hooks causes long delay times when running the low latency script to set the RPS mask (https://bugzilla.redhat.com/show_bug.cgi?id=2109965)

For RAN low latency solution it might be sufficient only to set the RPS on the host level and avoid setting it on the container level while utilizing RSS behavior.

In the past the low latency hook was added with RPS additional settings on virtual devices since there was an issue where the start and shutdown of big amount of pods will initiate the creation of the systemd service that should update the new interfaces rps_cpus mask and can create an additional CPU load under the cluster (https://github.com/openshift-kni/performance-addon-operators/pull/659) This might not be the case any more thus we need to examine how the revert of the aforementioned PR will behave now.

Co-authored-by: Yanir Quinn yquinn@redhat.com Signed-off-by: Talor Itzhak titzhak@redhat.com

openshift-ci-robot commented 1 year ago

@Tal-or: This pull request references Jira Issue OCPBUGS-4033, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift-kni/performance-addon-operators/pull/953): >RPS handling on pod container level using crio-hooks causes long delay times when running the low latency script to set the RPS mask (https://bugzilla.redhat.com/show_bug.cgi?id=2109965) > >For RAN low latency solution it might be sufficient only to set the RPS on the host level and avoid setting it on the container level while utilizing RSS behavior. > >In the past the low latency hook was added with RPS additional settings on virtual devices since there was an issue where the start and shutdown of big amount of pods will initiate the creation of the systemd service that should update the new interfaces rps_cpus mask and can create an additional CPU load under the cluster (https://github.com/openshift-kni/performance-addon-operators/pull/659) >This might not be the case any more thus we need to examine how the revert of the aforementioned PR will behave now. > >Co-authored-by: Yanir Quinn [yquinn@redhat.com](mailto:yquinn@redhat.com) >Signed-off-by: Talor Itzhak [titzhak@redhat.com](mailto:titzhak@redhat.com) Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
openshift-ci[bot] commented 1 year ago

@Tal-or: No Bugzilla bug is referenced in the title of this pull request. To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to [this](https://github.com/openshift-kni/performance-addon-operators/pull/953): >[release-4.10] [manual] OCPBUGS-4033: set RPS for veth on host level only Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
openshift-ci[bot] commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Tal-or

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift-kni/performance-addon-operators/blob/release-4.10/OWNERS)~~ [Tal-or] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
coveralls commented 1 year ago

Pull Request Test Coverage Report for Build 2645

Files with Coverage Reduction New Missed Lines %
pkg/controller/performanceprofile/components/machineconfig/machineconfig.go 12 79.4%
<!-- Total: 12 -->
Totals Coverage Status
Change from base Build 2631: -0.5%
Covered Lines: 1570
Relevant Lines: 2616
💛 - Coveralls
Tal-or commented 1 year ago

/jira refresh

Tal-or commented 1 year ago

/jira refresh

openshift-ci-robot commented 1 year ago

@Tal-or: This pull request references Jira Issue OCPBUGS-4033, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to [this](https://github.com/openshift-kni/performance-addon-operators/pull/953#issuecomment-1325172988): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
yanirq commented 1 year ago

Are all of the required tests aligned in this PR as well ?

Tal-or commented 1 year ago

Are all of the required tests aligned in this PR as well ?

We don't have an automated test for this feature if that's what you mean

yanirq commented 1 year ago

/lgtm

yanirq commented 1 year ago

/hold this is not blocked atm by 4.11 bug

Tal-or commented 1 year ago

/hold cancel The bot is making sure to block the PR until the bug depends on will shift into a valid state

Tal-or commented 1 year ago

/jira refresh

Tal-or commented 1 year ago

/jira refresh

Tal-or commented 1 year ago

/jira refresh bot doesn't respond

Tal-or commented 1 year ago

/jira refresh

openshift-ci-robot commented 1 year ago

@Tal-or: This pull request references Jira Issue OCPBUGS-4033, which is valid. The bug has been moved to the POST state.

6 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.10.z) matches configured target version for branch (4.10.z) * bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST) * dependent bug [Jira Issue OCPBUGS-3182](https://issues.redhat.com//browse/OCPBUGS-3182) is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE)) * dependent [Jira Issue OCPBUGS-3182](https://issues.redhat.com//browse/OCPBUGS-3182) targets the "4.11.z" version, which is one of the valid target versions: 4.11.0, 4.11.z * bug has dependents
In response to [this](https://github.com/openshift-kni/performance-addon-operators/pull/953#issuecomment-1329258628): >/jira refresh > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.