openshift-kni / performance-addon-operators

Operators related to optimizing OpenShift clusters for applications sensitive to cpu and network latency
Apache License 2.0
46 stars 60 forks source link

[release-4.10] OCPBUGS-4165: Add ktimer to PAO tuned profile #954

Closed jlojosnegros closed 1 year ago

jlojosnegros commented 1 year ago

Backport of openshift/cluster-node-tuning-operator#510

openshift-ci[bot] commented 1 year ago

@jlojosnegros: No Bugzilla bug is referenced in the title of this pull request. To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to [this](https://github.com/openshift-kni/performance-addon-operators/pull/954): >[release-4.10] OCPBUGS-4165: Add ktimer to PAO tuned profile Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
openshift-ci-robot commented 1 year ago

@jlojosnegros: This pull request references Jira Issue OCPBUGS-4165, which is invalid:

All dependent bugs must be part of the OCPBUGS project. If you are backporting a fix that was originally tracked in Bugzilla, follow these steps to handle the backport:

  1. Create a new bug in the OCPBUGS Jira project to match the original bugzilla bug. The important fields that should match are the title, description, target version, and status.
  2. Use the Jira UI to clone the Jira bug, then in the clone bug: a. Set the target version to the release you are cherrypicking to. b. Add an issue link “is blocked by”, which links to the original jira bug
  3. Use the cherrypick github command to create the cherrypicked PR. Once that new PR is created, retitle the PR and replace the BUG XXX: with OCPBUGS-XXX: to match the new Jira story.

Note that the mirrored bug in OCPBUGSM should not be involved in this process at all.

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift-kni/performance-addon-operators/pull/954): >Backport of openshift/cluster-node-tuning-operator#510 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
jlojosnegros commented 1 year ago

/jira refresh

coveralls commented 1 year ago

Pull Request Test Coverage Report for Build 2647


Totals Coverage Status
Change from base Build 2646: 0.0%
Covered Lines: 1570
Relevant Lines: 2616

💛 - Coveralls
openshift-ci-robot commented 1 year ago

@jlojosnegros: This pull request references Jira Issue OCPBUGS-4165, which is invalid:

All dependent bugs must be part of the OCPBUGS project. If you are backporting a fix that was originally tracked in Bugzilla, follow these steps to handle the backport:

  1. Create a new bug in the OCPBUGS Jira project to match the original bugzilla bug. The important fields that should match are the title, description, target version, and status.
  2. Use the Jira UI to clone the Jira bug, then in the clone bug: a. Set the target version to the release you are cherrypicking to. b. Add an issue link “is blocked by”, which links to the original jira bug
  3. Use the cherrypick github command to create the cherrypicked PR. Once that new PR is created, retitle the PR and replace the BUG XXX: with OCPBUGS-XXX: to match the new Jira story.

Note that the mirrored bug in OCPBUGSM should not be involved in this process at all.

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to [this](https://github.com/openshift-kni/performance-addon-operators/pull/954#issuecomment-1333456100): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
jlojosnegros commented 1 year ago

/jira refresh

openshift-ci-robot commented 1 year ago

@jlojosnegros: This pull request references Jira Issue OCPBUGS-4165, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to [this](https://github.com/openshift-kni/performance-addon-operators/pull/954#issuecomment-1333459397): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
jlojosnegros commented 1 year ago

/jira refresh

openshift-ci-robot commented 1 year ago

@jlojosnegros: This pull request references Jira Issue OCPBUGS-4165, which is valid. The bug has been moved to the POST state.

6 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.10.z) matches configured target version for branch (4.10.z) * bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST) * dependent bug [Jira Issue OCPBUGS-3474](https://issues.redhat.com//browse/OCPBUGS-3474) is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE)) * dependent [Jira Issue OCPBUGS-3474](https://issues.redhat.com//browse/OCPBUGS-3474) targets the "4.11.z" version, which is one of the valid target versions: 4.11.0, 4.11.z * bug has dependents

Requesting review from QA contact: /cc @gsr-shanks

In response to [this](https://github.com/openshift-kni/performance-addon-operators/pull/954#issuecomment-1333461554): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
ffromani commented 1 year ago

/lgtm

ffromani commented 1 year ago

do we have dependencies on tuned/rhcos components possibly not available on 4.10?

jlojosnegros commented 1 year ago

do we have dependencies on tuned/rhcos components possibly not available on 4.10?

We depend on the corresponding patch applied to the kernel but the ticket for that is closed so I think we are ok on that side.

openshift-ci[bot] commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jlojosnegros, MarSik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift-kni/performance-addon-operators/blob/release-4.10/OWNERS)~~ [MarSik] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci-robot commented 1 year ago

@jlojosnegros: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-4165 has been moved to the MODIFIED state.

In response to [this](https://github.com/openshift-kni/performance-addon-operators/pull/954): >Backport of openshift/cluster-node-tuning-operator#510 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.