search

openshift-kni / scheduler-plugins

Repository for out-of-tree scheduler plugins based on scheduler framework.
Apache License 2.0
1 stars 4 forks source link

[KNI] build: envtest: remove 'latest' floating tag refs #185

Closed ffromani closed 6 months ago

ffromani commented 6 months ago

never use floating tags in the build system, not even for CI tests. Always pin explicit versions.

openshift-ci[bot] commented 6 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ffromani

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[DOWNSTREAM_OWNERS](https://github.com/openshift-kni/scheduler-plugins/blob/master/DOWNSTREAM_OWNERS)~~ [ffromani] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
ffromani commented 6 months ago

/cherry-pick release-4.15

openshift-cherrypick-robot commented 6 months ago

@ffromani: once the present PR merges, I will cherry-pick it on top of release-4.15 in a new PR and assign it to you.

In response to [this](https://github.com/openshift-kni/scheduler-plugins/pull/185#issuecomment-2058928133): >/cherry-pick release-4.15 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
openshift-cherrypick-robot commented 6 months ago

@ffromani: new pull request created: #186

In response to [this](https://github.com/openshift-kni/scheduler-plugins/pull/185#issuecomment-2058928133): >/cherry-pick release-4.15 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.