openshift-kni / scheduler-plugins

Repository for out-of-tree scheduler plugins based on scheduler framework.
Apache License 2.0
1 stars 4 forks source link

OCPBUGS-33359: consume fix for ephemeral storage pods [resync 20240509] #199

Closed ffromani closed 5 months ago

ffromani commented 5 months ago

Add cherry-picks on top of current version: https://github.com/openshift-kni/scheduler-plugins/commit/cd54de85fe4d5cce32a5b71e59a4b0f9a7f7dddf update the NRT-related changes to consume the fix to deal with ephemeral storage.

openshift-ci[bot] commented 5 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ffromani

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[DOWNSTREAM_OWNERS](https://github.com/openshift-kni/scheduler-plugins/blob/release-4.12/DOWNSTREAM_OWNERS)~~ [ffromani] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
ffromani commented 5 months ago

/retest

openshift-ci-robot commented 5 months ago

@ffromani: This pull request references Jira Issue OCPBUGS-33359, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift-kni/scheduler-plugins/pull/199): >Add cherry-picks on top of current version: >https://github.com/openshift-kni/scheduler-plugins/commit/cd54de85fe4d5cce32a5b71e59a4b0f9a7f7dddf >update the NRT-related changes to consume the >fix to deal with ephemeral storage. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift-kni%2Fscheduler-plugins). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
ffromani commented 5 months ago

/jira refresh

openshift-ci-robot commented 5 months ago

@ffromani: This pull request references Jira Issue OCPBUGS-33359, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to [this](https://github.com/openshift-kni/scheduler-plugins/pull/199#issuecomment-2104327924): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift-kni%2Fscheduler-plugins). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
shajmakh commented 5 months ago

Thanks for this! lgtm. leaving room for others to review.

openshift-ci-robot commented 5 months ago

@ffromani: Jira Issue OCPBUGS-33359: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-33359 has been moved to the MODIFIED state.

In response to [this](https://github.com/openshift-kni/scheduler-plugins/pull/199): >Add cherry-picks on top of current version: >https://github.com/openshift-kni/scheduler-plugins/commit/cd54de85fe4d5cce32a5b71e59a4b0f9a7f7dddf >update the NRT-related changes to consume the >fix to deal with ephemeral storage. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift-kni%2Fscheduler-plugins). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.