search

openshift-kni / scheduler-plugins

Repository for out-of-tree scheduler plugins based on scheduler framework.
Apache License 2.0
1 stars 4 forks source link

[KNI][4.15] fix commit check #205

Closed ffromani closed 4 months ago

ffromani commented 4 months ago

The env var COMMITS may be empty. Handle it accordingly.

Signed-off-by: Francesco Romani fromani@redhat.com (cherry picked from commit 19127985f7cce4a175665fafba15127c763d5aa7)

openshift-ci[bot] commented 4 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ffromani

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[DOWNSTREAM_OWNERS](https://github.com/openshift-kni/scheduler-plugins/blob/release-4.15/DOWNSTREAM_OWNERS)~~ [ffromani] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
ffromani commented 4 months ago

/close

ffromani commented 4 months ago

/reopen

openshift-ci[bot] commented 4 months ago

@ffromani: Reopened this PR.

In response to [this](https://github.com/openshift-kni/scheduler-plugins/pull/205#issuecomment-2146943548): >/reopen Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
openshift-ci[bot] commented 4 months ago

@ffromani: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/images 24ce380211e00de2d155a73b78bbd2a424e84cbc link true /test images

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
ffromani commented 4 months ago

unrelated infra issue