search

openshift-kni / scheduler-plugins

Repository for out-of-tree scheduler plugins based on scheduler framework.
Apache License 2.0
1 stars 4 forks source link

[KNI] improve klogr compatibility #207

Closed ffromani closed 3 months ago

ffromani commented 4 months ago

the klogr wrapper should not serialize args but rather pass them through, because this is the behavior most similar to what we will have in 41.6 and onwards.

openshift-ci[bot] commented 4 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ffromani

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[DOWNSTREAM_OWNERS](https://github.com/openshift-kni/scheduler-plugins/blob/release-4.15/DOWNSTREAM_OWNERS)~~ [ffromani] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
ffromani commented 4 months ago

/retest

ffromani commented 3 months ago

before:

$ grep numaresources.go sched.old.log 
I0620 13:07:14.686527       1 numaresources.go:151]  "msg"="NUMA resources before" "cpu"="11" "logID"="default/numalign-pod-zrsq9/numalign" "memory"="6.7 GiB" "node"="node2.local.lab" "numaCell"=0
I0620 13:07:14.686573       1 numaresources.go:177]  "msg"="NUMA resources after" "cpu"="10" "logID"="default/numalign-pod-zrsq9/numalign" "memory"="6.5 GiB" "node"="node2.local.lab" "numaCell"=0
I0620 13:07:14.686693       1 numaresources.go:151]  "msg"="NUMA resources before" "cpu"="10" "logID"="default/numalign-pod-zrsq9/numalign" "memory"="6.5 GiB" "node"="ocp4152902292-worker-0.libvirt.lab.eng.tlv2.redhat.com" "numaCell"=0
I0620 13:07:14.686811       1 numaresources.go:177]  "msg"="NUMA resources after" "cpu"="9" "logID"="default/numalign-pod-zrsq9/numalign" "memory"="6.2 GiB" "node"="ocp4152902292-worker-0.libvirt.lab.eng.tlv2.redhat.com" "numaCell"=0

after:

$ grep numaresources.go sched.new.log 
I0620 12:58:29.205109       1 numaresources.go:151] "NUMA resources before" node="ocp4152902292-worker-0.libvirt.lab.eng.tlv2.redhat.com" numaCell=0 logID="default/numalign-pod-ddh2n/numalign" cpu="9" memory="6.2 GiB"
I0620 12:58:29.205156       1 numaresources.go:177] "NUMA resources after" node="ocp4152902292-worker-0.libvirt.lab.eng.tlv2.redhat.com" numaCell=0 logID="default/numalign-pod-ddh2n/numalign" cpu="8" memory="6.0 GiB"
I0620 12:58:29.205950       1 numaresources.go:151] "NUMA resources before" node="node2.local.lab" numaCell=0 logID="default/numalign-pod-ddh2n/numalign" cpu="11" memory="6.7 GiB"
I0620 12:58:29.206033       1 numaresources.go:177] "NUMA resources after" node="node2.local.lab" numaCell=0 logID="default/numalign-pod-ddh2n/numalign" cpu="10" memory="6.5 GiB"