hosted-workshop-production.json: Update workshop-jupyterhub to v2.10.2

openshift-labs / starter-guides

Getting Started with OpenShift for Developers workshop

https://openshift-labs.github.io/starter-guides-html/

Apache License 2.0

135 stars 146 forks source link

hosted-workshop-production.json: Update workshop-jupyterhub to v2.10.2 #129

Closed joshix closed 5 years ago

joshix commented 5 years ago

Ref https://trello.com/c/4N0ARkp7/224-update-starter-workshop-for-openshift-v4#comment-5c986771c0692516cae75ddf

GrahamDumpleton commented 5 years ago

Should work, but perhaps better to take a complete copy of:

https://raw.githubusercontent.com/openshift-labs/starter-guides/40a5e74d2331eb6c4b95f262174289b7b6105a6d/apb/roles/provision-java-starter-guides/templates/hosted-workshop-production.json

to keep in sync with whole template. The only difference is new template has ability to add annotations for lets encrypt if have openshift-acme installed.

joshix commented 5 years ago

I think you pasted the wrong URL (that points back to this same file in this project), but I understand. See https://github.com/openshift-labs/starter-guides/pull/130

and thanks. 💯

GrahamDumpleton commented 5 years ago

Details, details ....