openshift-labs / starter-guides

Getting Started with OpenShift for Developers workshop
https://openshift-labs.github.io/starter-guides-html/
Apache License 2.0
136 stars 147 forks source link

hosted-workshop-prod: Update to v3.0.5 #135

Closed joshix closed 5 years ago

joshix commented 5 years ago

Copy the latest release of hosted-workshop-production.json from https://github.com/openshift-labs/workshop-spawner/blob/3.0.5/templates/hosted-workshop-production.json

GrahamDumpleton commented 5 years ago

Does something elsewhere override APPLICATION_NAME template parameter when it is instantiated. I recollect the instance needing to be called terminal or terminals to matched documentation and links elsewhere. The prior version hadn't changed default value, so presuming it is overridden elsewhere.

joshix commented 5 years ago

Yes, in https://github.com/openshift-labs/starter-guides/blob/ab79bc255ab22b8743899c90c0031776cf54e668/apb/roles/provision-java-starter-guides/tasks/install-terminals.yml#L22