search

openshift-labs / starter-guides

Getting Started with OpenShift for Developers workshop
https://openshift-labs.github.io/starter-guides-html/
Apache License 2.0
135 stars 146 forks source link

Remove outdated Eclipse Che #137

Closed joshix closed 5 years ago

joshix commented 5 years ago

Delete references, templates for old Che. apb bundle prepare modifies Dockerfile. Tested on v4 cluster.

jorgemoralespou commented 5 years ago

@joshix Why do you want to remove Che? Shouldn't it be better to add Code Ready Workspaces instead of deleting it completely, if Che is old?

joshix commented 5 years ago

@jorgemoralespou 1) The che spec'd here doesn't work in deployments by @jankleinert and I (and you, I thought, based on earlier conversations). 2) It is my understanding that the Che deployed here is out of date, and that we would not reuse the existing Che bits in here to deploy Code Ready Workspaces (CRW). 3) Cleaning up the Che bits (this PR) is viewed as step one of potentially two, step two being later adding CRW.

I think "2)" must be where I misunderstood you and/or the problem. If 2) is not true, then we should close this PR and leave the Che vestiges in place.

jorgemoralespou commented 5 years ago

I'm ok with it. I'll test it in ocp 3.11 and if it works, I'll merge.