search

openshift-labs / starter-guides

Getting Started with OpenShift for Developers workshop
https://openshift-labs.github.io/starter-guides-html/
Apache License 2.0
136 stars 147 forks source link

The .config directory should not be checked into Git repsitory. #147

Closed GrahamDumpleton closed 3 years ago

GrahamDumpleton commented 4 years ago

@jankleinert @jorgemoralespou

Not sure how you managed to get it in there in ocp-4.2 branch, but the .config directory should not be checked into the Git repository. Can only think maybe workshop-dashboard image was run locally with working directory mounted and so that directory from running container was written back and then accidentally added to Git repository.

jorgemoralespou commented 4 years ago

My fault. I did run it locally with mounted sources.

El mié., 28 ago. 2019 3:57, Graham Dumpleton notifications@github.com escribió:

@jankleinert https://github.com/jankleinert @jorgemoralespou https://github.com/jorgemoralespou

Not sure how you managed to get it in there in ocp-4.2 branch, but the .config directory should not be checked into the Git repository. Can only think maybe workshop-dashboard image was run locally with working directory mounted and so that directory from running container was written back and then accidentally added to Git repository.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/openshift-labs/starter-guides/issues/147?email_source=notifications&email_token=AAATEDVWS7TE7E6IODI6PBDQGXLQZA5CNFSM4IQVQ3E2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HHZSZZA, or mute the thread https://github.com/notifications/unsubscribe-auth/AAATEDQOGNIME7OC2RIGRRLQGXLQZANCNFSM4IQVQ3EQ .