openshift-labs / starter-guides

Getting Started with OpenShift for Developers workshop
https://openshift-labs.github.io/starter-guides-html/
Apache License 2.0
135 stars 146 forks source link

Don't show image trigger on dc/nationalparks #30

Closed ganto closed 7 years ago

ganto commented 7 years ago

When following the workshop the trigger was removed before creating the nationalparks-pipeline. Therefore it shouldn't' show up, when listing the deploymentconfig.

See https://github.com/osevg/workshopper-content/blame/master/pipelines.adoc#L297

siamaksade commented 7 years ago

The pipeline module might not be included in the workshop and in that case the image trigger would be there.

This should be done in a conditional statement:

{% if modules.pipelines %}
dc list without trigger
{% else %}
dc list with trigger
{% endif %}
ganto commented 7 years ago

Thanks for the feedback. Adjusted code accordingly.