openshift-labs / starter-guides

Getting Started with OpenShift for Developers workshop
https://openshift-labs.github.io/starter-guides-html/
Apache License 2.0
135 stars 146 forks source link

oc client version links updated in _modules.yml #43

Closed kmurudi closed 6 years ago

jorgemoralespou commented 7 years ago

@kmurudi The _modules.yml was updated with correct links from previous PR, but the install.adoc can remain. If you remove the _modules.yml I'll merge it.

Or, you can close the PR, and I'll add it. I'd rather have your contribution, but it's up to you.

kmurudi commented 7 years ago

Hi Jorge,

So, I'll remove the _modules.yml folder from my local repo and then submit a PR?

Regards, Kshitija Murudi

On Mon, Jun 26, 2017 at 5:34 AM, Jorge Morales Pou <notifications@github.com

wrote:

@kmurudi https://github.com/kmurudi The _modules.yml was updated with correct links from previous PR, but the install.adoc can remain. If you remove the _modules.yml I'll merge it.

Or, you can close the PR, and I'll add it. I'd rather have your contribution, but it's up to you.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/osevg/workshopper-content/pull/43#issuecomment-311010451, or mute the thread https://github.com/notifications/unsubscribe-auth/AZHYTpwckY-mhIa1BgAnP2vFE3KXmfbuks5sH3stgaJpZM4OD8fV .

jorgemoralespou commented 7 years ago

Yes, but if you can squash the commit, then it'll be easier. Else, you can just open a new PR with just the change in install.adoc (That's what I usually do as I'm no git expert).

jorgemoralespou commented 7 years ago

@kmurudi Still you have deleted the file, which will delete it in our repo.

I would just recommend you doing a new PR with the only change in install.adoc

kmurudi commented 7 years ago

Sure, I shall do that and submit a new PR

jorgemoralespou commented 6 years ago

This has already been fixed