search

openshift-labs / starter-guides

Getting Started with OpenShift for Developers workshop
https://openshift-labs.github.io/starter-guides-html/
Apache License 2.0
135 stars 146 forks source link

Variablize storage type and consolidate SUFFIX into USER_SUFFIX #61

Closed gregswift closed 5 years ago

gregswift commented 7 years ago

SUFFIX was used in one place as a reference back to the USER_SUFFIX, but had to be defined separately. Doesn't really make sense, imo.

Internally we wanted to be able to show people how to use the persistent storage a bit, and it takes up less disk on the worker nodes, so we wanted to be able to set that in the roadshow. So we added that as a variable, defaulting to ephemeral.

gregswift commented 7 years ago

Can split easily if needed.

jorgemoralespou commented 6 years ago

I would merged the storage one if splitted.

The SUFFIX one, depends on the values you set for USER_SUFFIX. If you look into the defaults, it would not work.

I'll take a look into fixing this in a better way soon.

jorgemoralespou commented 6 years ago

Also, make the PR for the appropriate branch, or indicate what branch you use, since master is for 3.7 content that I'll work on it soon. There's a 36 and 35 branch for content targeting those versions.

jorgemoralespou commented 5 years ago

Not relevant anymore