search

openshift-labs / starter-guides

Getting Started with OpenShift for Developers workshop
https://openshift-labs.github.io/starter-guides-html/
Apache License 2.0
135 stars 147 forks source link

Adding js-training.yml (workshop modules for nationalparks-js) #86

Closed ryanj closed 5 years ago

ryanj commented 6 years ago

Preview available here: http://workshop-worktown.b9ad.pro-us-east-1.openshiftapps.com/

jorgemoralespou commented 6 years ago

@ryanj there's changes missing in the web hook chapter

ryanj commented 6 years ago

Thanks @jorgemoralespou - Changes pushed

I think it's ready for another look

ryanj commented 6 years ago

Most of my changes are new files, but I did not duplicate the codechanges.adoc file.

It might be a good idea to re-test the other training content (which also depends on codechanges.adoc) - to make sure I didn't break anyone else's content.

ryanj commented 6 years ago

cc @marekjelen

jorgemoralespou commented 5 years ago

This should already be fixed. There's a https://github.com/openshift-labs/starter-guides/blob/ocp-3.9/_workshops/javascript-starter-guides.yml definition