search

openshift-metal3 / dev-scripts

Scripts to automate development/test setup for openshift integration with https://github.com/metal3-io/
Apache License 2.0
94 stars 186 forks source link

Agent: Move userManagedNetworking under networking #1553

Closed zaneb closed 1 year ago

zaneb commented 1 year ago

This data ended up one level too high, which broke SNO CI.

zaneb commented 1 year ago

/cc @rwsu

zaneb commented 1 year ago

/test images /override ci/prow/e2e-agent-compact

openshift-ci[bot] commented 1 year ago

@zaneb: Overrode contexts on behalf of zaneb: ci/prow/e2e-agent-compact

In response to [this](https://github.com/openshift-metal3/dev-scripts/pull/1553#issuecomment-1644995338): >/test images >/override ci/prow/e2e-agent-compact Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
andfasano commented 1 year ago

/lgtm

Wondering how the original patch passed for the SNO job

zaneb commented 1 year ago

Wondering how the original patch passed for the SNO job

It didn't. It failed to get a lease from Equinix so the error wasn't visible, and the job isn't required so it merged anyway.

bfournie commented 1 year ago

/approve

openshift-ci[bot] commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bfournie

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[agent/OWNERS](https://github.com/openshift-metal3/dev-scripts/blob/master/agent/OWNERS)~~ [bfournie] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment