search

openshift-metal3 / dev-scripts

Scripts to automate development/test setup for openshift integration with https://github.com/metal3-io/
Apache License 2.0
94 stars 186 forks source link

appliance: ensure config-image is created once #1561

Closed danielerez closed 1 year ago

danielerez commented 1 year ago

The config-image should be created only once (as the ISO is shared by all machines). Hence, moved the config-image creation logic outside of the 'attach_appliance_diskimage' func. I.e. Since this func is called twice (both for masters and workers).

openshift-ci[bot] commented 1 year ago

Hi @danielerez. Thanks for your PR.

I'm waiting for a openshift-metal3 member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
danielerez commented 1 year ago

/cc @bfournie /cc @andfasano /cc @rwsu

andfasano commented 1 year ago

/ok-to-test

andfasano commented 1 year ago

/lgtm

As a side note, I think it'd be useful to have an appliance job, even optional, in dev-scripts openshift/release CI, so that it could be possible to verify/tests those PRs directly in the CI (without the need to run them locally) cc @bfournie @rwsu

bfournie commented 1 year ago

/retest

danielerez commented 1 year ago

/lgtm

As a side note, I think it'd be useful to have an appliance job, even optional, in dev-scripts openshift/release CI, so that it could be possible to verify/tests those PRs directly in the CI (without the need to run them locally) cc @bfournie @rwsu

Already working on it :) https://github.com/openshift/release/pull/42043 Will probably also add some job to the installer/agent.

openshift-ci[bot] commented 1 year ago

@danielerez: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-agent-ha-dualstack 4f8e2a93864a5ee6d613174413741812dc4e20d8 link false /test e2e-agent-ha-dualstack

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
danielerez commented 1 year ago

/retest

bfournie commented 1 year ago

/approve

openshift-ci[bot] commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bfournie

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[agent/OWNERS](https://github.com/openshift-metal3/dev-scripts/blob/master/agent/OWNERS)~~ [bfournie] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment