openshift-metal3 / dev-scripts

Scripts to automate development/test setup for openshift integration with https://github.com/metal3-io/
Apache License 2.0
93 stars 185 forks source link

utils: fix mechanism for mirroring OLM operators #1563

Closed mkowalski closed 1 year ago

mkowalski commented 1 year ago

/cc @cybertron

mkowalski commented 1 year ago

Tested manually using disconnected IPv6 setup

# oc get catalogsource -A
NAMESPACE               NAME                     DISPLAY                                                                                    TYPE   PUBLISHER   AGE
openshift-marketplace   mirror-catalog-for-olm   Mirror index for OLM packages from registry.redhat.io/redhat/redhat-operator-index:v4.13   grpc   Local       11m
# oc get catalogsource mirror-catalog-for-olm -n openshift-marketplace -o yaml
apiVersion: operators.coreos.com/v1alpha1
kind: CatalogSource
[...]
spec:
  displayName: Mirror index for OLM packages from registry.redhat.io/redhat/redhat-operator-index:v4.13
  grpcPodConfig:
    securityContextConfig: restricted
  image: virthost.ostest.test.metalkube.org:5000/olm-index/redhat-operator-index:v4.13
  publisher: Local
  sourceType: grpc
  updateStrategy:
    registryPoll:
      interval: 30m
status:
  connectionState:
    address: mirror-catalog-for-olm.openshift-marketplace.svc:50051
    lastConnect: "2023-08-09T14:42:11Z"
    lastObservedState: READY
  registryService:
    createdAt: "2023-08-09T14:39:28Z"
    port: "50051"
    protocol: grpc
    serviceName: mirror-catalog-for-olm
    serviceNamespace: openshift-marketplace
# oc get clusterserviceversion -n openshift-nmstate
NAME                                              DISPLAY                       VERSION               REPLACES   PHASE
kubernetes-nmstate-operator.4.13.0-202307242035   Kubernetes NMState Operator   4.13.0-202307242035              Succeeded
openshift-ci[bot] commented 1 year ago

@mkowalski: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-metal-ipi-ovn-dualstack ca65070e7572e9e1f6b428be1debedb54e081333 link false /test e2e-metal-ipi-ovn-dualstack
ci/prow/e2e-metal-ipi-serial-ovn-ipv6 ca65070e7572e9e1f6b428be1debedb54e081333 link false /test e2e-metal-ipi-serial-ovn-ipv6
ci/prow/e2e-agent-ha-dualstack ca65070e7572e9e1f6b428be1debedb54e081333 link false /test e2e-agent-ha-dualstack

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
cybertron commented 1 year ago

/lgtm

The previous version of this worked for me locally, and I believe the only change in this one is how we deploy the manifests.

mkowalski commented 1 year ago

/test e2e-metal-ipi-serial-ipv4

cybertron commented 1 year ago

/approve

Riccardo previously lgtm'd this too and it doesn't affect any of the existing ci jobs on this repo so this didn't break any of the failing optional jobs.

openshift-ci[bot] commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cybertron

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift-metal3/dev-scripts/blob/master/OWNERS)~~ [cybertron] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment