search

openshift-metal3 / dev-scripts

Scripts to automate development/test setup for openshift integration with https://github.com/metal3-io/
Apache License 2.0
94 stars 186 forks source link

utils: allow mirroring single container image #1565

Closed mkowalski closed 1 year ago

openshift-ci[bot] commented 1 year ago

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

mkowalski commented 1 year ago

/cc @cybertron

mkowalski commented 1 year ago

Required-for: https://github.com/openshift/release/pull/42097

mkowalski commented 1 year ago

/retest-required

mkowalski commented 1 year ago

/retest-required

cybertron commented 1 year ago

/lgtm

Tested this locally and I can see that the image was successfully mirrored into my local registry. Since it's not being used in any of the ci jobs yet I don't see how it could have caused the couple of remaining failures.

derekhiggins commented 1 year ago

lgtm but before adding it just thought I'd point out the mirroring support to ASSETS_EXTRA_FOLDER that merged recently https://github.com/openshift-metal3/dev-scripts/pull/1569/files does this help your usecase? is this still needed?

mkowalski commented 1 year ago

lgtm but before adding it just thought I'd point out the mirroring support to ASSETS_EXTRA_FOLDER that merged recently https://github.com/openshift-metal3/dev-scripts/pull/1569/files does this help your usecase? is this still needed?

Yes and no... If I read it correctly (correct if I'm wrong) this works in a way that I would need to craft a manifest deploying something, place this manifest in the ASSETS_EXTRA_FOLDER and then machinery takes care so that images used by the manifest are mirrored and manifest is updated to use the mirror.

But in our use case there is no any manifest anywhere, what we need is only a vanilla set of images present in our local registry. Later on we may or may not deploy something that uses them, but the main issue I see is that we do not have any manifest at install-time.

To put even more there, we may be deploying workload that needs an image from the local registry and then this thing that we deployed will deploy something else what also needs a local image (kind of a container deploying next containers)

Not sure if that explains my use case well but I'm happy to clarify further

derekhiggins commented 1 year ago

/approve

Not sure if that explains my use case well but I'm happy to clarify further

Yup, makes sense, thanks for the explanation,

openshift-ci[bot] commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: derekhiggins

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift-metal3/dev-scripts/blob/master/OWNERS)~~ [derekhiggins] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci[bot] commented 1 year ago

@mkowalski: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-metal-ipi-virtualmedia 99d7b84ec290b42451af61455bd1bceb5e17985d link false /test e2e-metal-ipi-virtualmedia
ci/prow/e2e-agent-ha-dualstack 99d7b84ec290b42451af61455bd1bceb5e17985d link false /test e2e-agent-ha-dualstack

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
mkowalski commented 1 year ago

/test e2e-metal-ipi-serial-ipv4