openshift-metal3 / dev-scripts

Scripts to automate development/test setup for openshift integration with https://github.com/metal3-io/
Apache License 2.0
93 stars 185 forks source link

Allow pushing custom image names when preparing a release #1581

Closed andfasano closed 11 months ago

andfasano commented 1 year ago

In some cases it may be useful to provide a custom image name - rather than using the folder name as a default - when preparing a local release. This is particularly useful for the agent-based installer, since the same repo may be used to produce (more than one) different images shipped in the release payload (having their own name).

Also, enabling automatically local registry when using custom images also for the agent workflow

bfournie commented 1 year ago

/lgtm although it would be very helpful to add instructions to agent/README.md about how to use this and also include the comments in https://github.com/openshift-metal3/dev-scripts/blob/master/agent/04_agent_prepare_release.sh#L16-L21 in the README

andfasano commented 1 year ago

/lgtm although it would be very helpful to add instructions to agent/README.md about how to use this and also include the comments in https://github.com/openshift-metal3/dev-scripts/blob/master/agent/04_agent_prepare_release.sh#L16-L21 in the README

Meanwhile I've slightly enhanced the 04 step readme, I'll plan to followup more detailed instructions for managing more than one repo changes in a subsequent PR

bfournie commented 11 months ago

/lgtm

andfasano commented 11 months ago

/lgtm although it would be very helpful to add instructions to agent/README.md about how to use this and also include the comments in https://github.com/openshift-metal3/dev-scripts/blob/master/agent/04_agent_prepare_release.sh#L16-L21 in the README

Meanwhile I've slightly enhanced the 04 step readme, I'll plan to followup more detailed instructions for managing more than one repo changes in a subsequent PR

FYI https://github.com/openshift-metal3/dev-scripts/pull/1590

openshift-ci[bot] commented 11 months ago

@andfasano: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-agent-sno-ipv6 ddf8281496e5acab2526c4d0bae374c7c4fdf257 link false /test e2e-agent-sno-ipv6
ci/prow/e2e-metal-ipi-serial-ovn-ipv6 ddf8281496e5acab2526c4d0bae374c7c4fdf257 link false /test e2e-metal-ipi-serial-ovn-ipv6

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
pawanpinjarkar commented 11 months ago

/lgtm

bfournie commented 11 months ago

/approve

openshift-ci[bot] commented 11 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bfournie

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift-metal3/dev-scripts/blob/master/OWNERS)~~ [bfournie] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment