search

openshift-metal3 / dev-scripts

Scripts to automate development/test setup for openshift integration with https://github.com/metal3-io/
Apache License 2.0
94 stars 186 forks source link

Set net.ipv6.conf.all.accept_ra=2 for all topologies #1583

Closed mkowalski closed 1 year ago

mkowalski commented 1 year ago

In specific scenarios we deploy dual-stack NICs even if the host is configured as IPv4 stack (e.g. when testing multi NIC with nmstate). In this situation we forgot to set accept_ra what causes deployment to fail.

With this change we will set accept_ra no matter the topology of the cluster so that we can have all types of VMs created.

dtantsur commented 1 year ago

/approve

openshift-ci[bot] commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dtantsur

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift-metal3/dev-scripts/blob/master/OWNERS)~~ [dtantsur] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
andfasano commented 1 year ago

/test e2e-metal-ipi-ovn-dualstack /test e2e-agent-sno-ipv6

andfasano commented 1 year ago

/retest

cybertron commented 1 year ago

/lgtm

I guess this was a libvirt change? We've been doing v4 clusters with dual stack extra nics for a long time and it always worked.