openshift-metal3 / dev-scripts

Scripts to automate development/test setup for openshift integration with https://github.com/metal3-io/
Apache License 2.0
93 stars 185 forks source link

OCPBUGS-19676: Allow agent VSphere installs by simulating VMWare host #1588

Closed bfournie closed 10 months ago

bfournie commented 11 months ago

When the platform type is "vsphere", set the host's manufacturer to VMWare in order to pass the assisted-service validations and allow the installation to proceed.

openshift-ci[bot] commented 10 months ago

New changes are detected. LGTM label has been removed.

andfasano commented 10 months ago

/approve

openshift-ci[bot] commented 10 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andfasano

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[agent/OWNERS](https://github.com/openshift-metal3/dev-scripts/blob/master/agent/OWNERS)~~ [andfasano] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment