search

openshift-metal3 / dev-scripts

Scripts to automate development/test setup for openshift integration with https://github.com/metal3-io/
Apache License 2.0
93 stars 185 forks source link

Skip host FIPS validation in installer by default #1591

Closed zaneb closed 11 months ago

zaneb commented 11 months ago

Since CI hosts do not run with FIPS mode enabled, disable checking for it in openshift-install by default. This setting can be overridden in the config by setting FIPS_VALIDATE=true.

derekhiggins commented 11 months ago

sounds good to me, looks like it needs a small update

common.sh: line 129: FIPS_MODE: unbound variable

zaneb commented 11 months ago

fixed, thanks

zaneb commented 11 months ago

/cc @bfournie @andfasano

zaneb commented 11 months ago

/retest-required

zaneb commented 11 months ago

/retest-required

openshift-ci[bot] commented 11 months ago

@zaneb: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-agent-sno-ipv6 2afef6d4ec50488a585a35cd146ee3a00fd415f2 link false /test e2e-agent-sno-ipv6

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
derekhiggins commented 11 months ago

/lgtm

openshift-ci[bot] commented 11 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andfasano

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift-metal3/dev-scripts/blob/master/OWNERS)~~ [andfasano] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
zaneb commented 11 months ago

/override ci/prow/e2e-metal-ipi-serial-ovn-ipv6

openshift-ci[bot] commented 11 months ago

@zaneb: Overrode contexts on behalf of zaneb: ci/prow/e2e-metal-ipi-serial-ovn-ipv6

In response to [this](https://github.com/openshift-metal3/dev-scripts/pull/1591#issuecomment-1753918873): >/override ci/prow/e2e-metal-ipi-serial-ovn-ipv6 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
zaneb commented 11 months ago

/override ci/prow/e2e-metal-ipi-ovn-ipv6

openshift-ci[bot] commented 11 months ago

@zaneb: Overrode contexts on behalf of zaneb: ci/prow/e2e-metal-ipi-ovn-ipv6

In response to [this](https://github.com/openshift-metal3/dev-scripts/pull/1591#issuecomment-1753964284): >/override ci/prow/e2e-metal-ipi-ovn-ipv6 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.