search

openshift-metal3 / dev-scripts

Scripts to automate development/test setup for openshift integration with https://github.com/metal3-io/
Apache License 2.0
93 stars 185 forks source link

Mirror manifest lists and use authfile explicitly #1592

Closed mkowalski closed 11 months ago

mkowalski commented 11 months ago

We have observed that in specific environments (e.g. CI with IPv6-only) there are missing default credentials for the local registry hosted at virthost.ostest.test.metalkube.org:5000 what causes errors like

Trying to pull [...]
Error: initializing source docker://virthost.ostest.test [...]
[...] /localimages/local-release-image: authentication required

In order to fix that, we are trying to explicitly pull the image with --authfile so that the subsequent podman run has the image already available.

We have also noticed that when release image constains manifest list but the list contains only a single image, then oc adm release mirror unpacks the list causing digests of the images to change. In order to prevent that, we are explicitly requesting that manifest lists are kept without unpacking.

This should solve the problem of inconsistency between results returned by oc adm release info and oc adm release mirror.

openshift-ci[bot] commented 11 months ago

@mkowalski: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-agent-sno-ipv6 6cbf2d83d2617de9689c3d8cd200d83d805a96f5 link false /test e2e-agent-sno-ipv6

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
derekhiggins commented 11 months ago

/test e2e-metal-ipi-bm /lgtm

dtantsur commented 11 months ago

/approve

openshift-ci[bot] commented 11 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dtantsur

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift-metal3/dev-scripts/blob/master/OWNERS)~~ [dtantsur] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment