AGENT-742: Add baremetal host BMC configuration to install-config

[bfournie]

For the agent installer, add fields to install-config.yaml for the BMC and provisioning network. This allows baremetal hosts to be set up at install time.

[rwsu]

It wasn't obvious to me from looking at this PR alone. To test this, you'll need to set export AGENT_BM_HOSTS_IN_INSTALL_CONFIG=true.

[bfournie]

/retest-required

[ahussey-redhat]

That makes sense :)

On Wed, 29 Nov 2023, 04:47 Bob Fournier, @.***> wrote:

@.**** commented on this pull request.

In agent/roles/manifests/templates/install-config_baremetal_yaml.j2 https://github.com/openshift-metal3/dev-scripts/pull/1601#discussion_r1408153203 :

 hosts:

{% for hostname in hostnames %}

• name: {{ hostname }} bootMACAddress: {{ macs[loop.index0] }}
• bmc:
• address: {{ bmc_addresses[loop.index0] }}
• username: {{ bmc_usernames[loop.index0] }}
• password: {{ bmc_passwords[loop.index0] }}
• disableCertificateVerification: false

Thanks @ahussey-redhat https://github.com/ahussey-redhat. So this setting doesn't affect the installation or the resulting baremetalhosts, and making it configurable would just require a new environment variable which wouldn't be used in any CI tests so I don't think we need it to be configurable.

— Reply to this email directly, view it on GitHub https://github.com/openshift-metal3/dev-scripts/pull/1601#discussion_r1408153203, or unsubscribe https://github.com/notifications/unsubscribe-auth/AWGJ7GF3QK7YQJDAJFPANWDYGYPRHAVCNFSM6AAAAAA7DCKSSCVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTONJTGUZDGMZSGQ . You are receiving this because you were mentioned.Message ID: @.***>

[bfournie]

/retest

[bfournie]

/test e2e-metal-ipi-ovn-dualstack

[andfasano]

/approve

[openshift-ci[bot]]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andfasano

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift-metal3/dev-scripts/blob/master/OWNERS)~~ [andfasano] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

[bfournie]

/test e2e-metal-ipi-serial-ipv4

[bfournie]

/retest-required