search

openshift-metal3 / dev-scripts

Scripts to automate development/test setup for openshift integration with https://github.com/metal3-io/
Apache License 2.0
93 stars 185 forks source link

AGENT-337: When using ZTP manifests, support both VIP and VIPs #1604

Closed bfournie closed 9 months ago

bfournie commented 9 months ago

In agent_cluster_install.yaml, include VIPS in addition to VIP to be compatible with the assisted-service change. https://github.com/openshift/assisted-service/pull/5501

bfournie commented 9 months ago

/cc @andfasano

openshift-ci[bot] commented 9 months ago

@nmagnezi: changing LGTM is restricted to collaborators

In response to [this](https://github.com/openshift-metal3/dev-scripts/pull/1604#pullrequestreview-1738457492): >/lgtm Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
filanov commented 9 months ago

/approve

filanov commented 9 months ago

@zaneb can you please approve?

andfasano commented 9 months ago

/approve

openshift-ci[bot] commented 9 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andfasano, filanov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[agent/OWNERS](https://github.com/openshift-metal3/dev-scripts/blob/master/agent/OWNERS)~~ [andfasano] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
zaneb commented 9 months ago

@filanov was this blocking something? Not opposed to merging this, but if it was blocking something then the thing it was blocking will break users.

filanov commented 9 months ago

in the latest version we removed api vip and ingress vip and replaced with api vips and ingress vips the api was marked as deprecated for a year and now we removed it

bfournie commented 9 months ago

I don't believe this fixed a blocking issue, Nir and I had verified that the singular work still worked with agent-cluster-install.yaml. It just is consistent now with the API. Also multiple VIPs are now supported in agent dev-scripts ZTP testing, this was an earlier oversight.

zaneb commented 9 months ago

in the latest version we removed api vip and ingress vip and replaced with api vips and ingress vips the api was marked as deprecated for a year and now we removed it

@filanov we don't remove fields from a kube API, you can only create a new version of the API without that field. But I believe that Nir and Bob have it under control.

filanov commented 9 months ago

Yes we are adding a new api version, v1beta2

filanov commented 9 months ago

@carbonin is taking over that work from Nir