search

openshift-metal3 / dev-scripts

Scripts to automate development/test setup for openshift integration with https://github.com/metal3-io/
Apache License 2.0
93 stars 185 forks source link

Remove gpasswd command call #1605

Closed cjeanner closed 9 months ago

cjeanner commented 9 months ago

gpasswd does the same as the usermod call we have just before. It was mostly a mix with the newgrp command, but it doesn't help either.

Since there's no way to reload the groups system wide without a logout and login, we can't really do anything...

openshift-ci[bot] commented 9 months ago

Hi @cjeanner. Thanks for your PR.

I'm waiting for a openshift-metal3 member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
dtantsur commented 9 months ago

/ok-to-test

dtantsur commented 9 months ago

/approve /hold

https://github.com/metal3-io/metal3-dev-env/pull/1317/ must merge first

openshift-ci[bot] commented 9 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dtantsur

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift-metal3/dev-scripts/blob/master/OWNERS)~~ [dtantsur] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
cjeanner commented 9 months ago

/retest-required

cjeanner commented 9 months ago

/retest-required

cjeanner commented 9 months ago

@dtantsur the related patch has been merged in the other project. The discussion I had there lead to "just remove the thing supposed to (not) reload groups and be off with that". Lemme know if this is also OK on this side.

TLDR; no way to reload groups, logout/login is needed, but due to CI and automation we may not be able to enforce this.

elfosardo commented 9 months ago

/unhold

elfosardo commented 9 months ago

/retest

elfosardo commented 9 months ago

this should be ok, and we were missing sudo anyway let's see what the CI says

elfosardo commented 9 months ago

/lgtm

cjeanner commented 9 months ago

/test e2e-metal-ipi-serial-ipv4