search

openshift-metal3 / dev-scripts

Scripts to automate development/test setup for openshift integration with https://github.com/metal3-io/
Apache License 2.0
93 stars 185 forks source link

Add build arg to custom release #1609

Closed andfasano closed 10 months ago

andfasano commented 10 months ago

This patch adds the possibility to specify an additional build arg when building a local repo. In addition, it ensures that the installer will be extracted from the mirror, so that the subsequent steps will use the updated one - in case it was just rebuilt (this feature will avoid specifying export KNI_INSTALL_FROM_GIT=true when using a custom release)

bfournie commented 10 months ago

/approve

openshift-ci[bot] commented 10 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bfournie

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[agent/OWNERS](https://github.com/openshift-metal3/dev-scripts/blob/master/agent/OWNERS)~~ [bfournie] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment