search

openshift-metal3 / dev-scripts

Scripts to automate development/test setup for openshift integration with https://github.com/metal3-io/
Apache License 2.0
93 stars 185 forks source link

Revert "OCPBUGS-15056: Use v4 network for v4-primary dual stack (#1534)" #1610

Closed danielerez closed 9 months ago

danielerez commented 9 months ago

This reverts commit d96ef53d6ba06300f2e7c5c42db2e6907153ec96.

The revert is done to prevent duplicate DNS records in ostestbm network. E.g.

[2023-11-23 13:42:15]   <dns>
[2023-11-23 13:42:15]     <forwarder domain='apps.ostest.test.metalkube.org' addr='127.0.0.1'/>
[2023-11-23 13:42:15]     <host ip='fd2e:6f44:5dd8:c956::5'>
[2023-11-23 13:42:15]       <hostname>api</hostname>
[2023-11-23 13:42:15]     </host>
[2023-11-23 13:42:15]     <host ip='fd2e:6f44:5dd8:c956::2'>
[2023-11-23 13:42:15]       <hostname>ns1</hostname>
[2023-11-23 13:42:15]     </host>
[2023-11-23 13:42:15]     <host ip='fd2e:6f44:5dd8:c956::1'>
[2023-11-23 13:42:15]       <hostname>virthost</hostname>
[2023-11-23 13:42:15]     </host>
[2023-11-23 13:42:15]     <host ip='fd2e:6f44:5dd8:c956::5'>
[2023-11-23 13:42:15]       <hostname>api</hostname>
[2023-11-23 13:42:15]     </host>
[2023-11-23 13:42:15]     <host ip='fd2e:6f44:5dd8:c956::1'>
[2023-11-23 13:42:15]       <hostname>virthost</hostname>
[2023-11-23 13:42:15]     </host>
[2023-11-23 13:42:15]   </dns>
danielerez commented 9 months ago

/test ?

openshift-ci[bot] commented 9 months ago

Hi @danielerez. Thanks for your PR.

I'm waiting for a openshift-metal3 member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
openshift-ci[bot] commented 9 months ago

@danielerez: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to [this](https://github.com/openshift-metal3/dev-scripts/pull/1610#issuecomment-1831846144): >/test ? Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
bfournie commented 9 months ago

/ok-to-test

danielerez commented 9 months ago

/test ?

openshift-ci[bot] commented 9 months ago

@danielerez: The following commands are available to trigger required jobs:

The following commands are available to trigger optional jobs:

Use /test all to run the following jobs that were automatically triggered:

In response to [this](https://github.com/openshift-metal3/dev-scripts/pull/1610#issuecomment-1831855826): >/test ? Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
danielerez commented 9 months ago

/test edge-e2e-ai-operator-ztp-disconnected

openshift-ci[bot] commented 9 months ago

@danielerez: The specified target(s) for /test were not found. The following commands are available to trigger required jobs:

The following commands are available to trigger optional jobs:

Use /test all to run the following jobs that were automatically triggered:

In response to [this](https://github.com/openshift-metal3/dev-scripts/pull/1610#issuecomment-1831857979): >/test edge-e2e-ai-operator-ztp-disconnected Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
danielerez commented 9 months ago

/test pull-ci-openshift-assisted-service-master-edge-e2e-ai-operator-ztp-disconnected

openshift-ci[bot] commented 9 months ago

@danielerez: The specified target(s) for /test were not found. The following commands are available to trigger required jobs:

The following commands are available to trigger optional jobs:

Use /test all to run the following jobs that were automatically triggered:

In response to [this](https://github.com/openshift-metal3/dev-scripts/pull/1610#issuecomment-1831859905): >/test pull-ci-openshift-assisted-service-master-edge-e2e-ai-operator-ztp-disconnected Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
cybertron commented 9 months ago

/retest /lgtm

I'm fine with reverting this. I believe it was only needed to enable a non-default configuration in dev-scripts which is unlikely to be an issue for anyone. The impact of keeping the change is much larger than the impact of removing it.

danielerez commented 9 months ago

/retest

openshift-ci[bot] commented 9 months ago

@danielerez: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-metal-ipi-bm-bond e2e0b13cc038c71742386c3e8e5d495c90af685d link false /test e2e-metal-ipi-bm-bond

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
danielerez commented 9 months ago

/retest-required

bfournie commented 9 months ago

/approve

openshift-ci[bot] commented 9 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bfournie

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift-metal3/dev-scripts/blob/master/OWNERS)~~ [bfournie] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment