search

openshift-metal3 / dev-scripts

Scripts to automate development/test setup for openshift integration with https://github.com/metal3-io/
Apache License 2.0
93 stars 185 forks source link

AGENT-736: Dev-script support for generic external platform #1611

Closed pawanpinjarkar closed 9 months ago

pawanpinjarkar commented 9 months ago

Can be tested by setting 


export IP_STACK="v4"
export AGENT_E2E_TEST_SCENARIO=SNO_IPV4
export KNI_INSTALL_FROM_GIT=true
export INSTALLER_REPO_PR=7585
export AGENT_PLATFORM_TYPE=external
export AGENT_PLATFORM_NAME=oci
export AGENT_INSTALLER_API_SERVER_LOCAL_REPO=/home/pawan/assisted-service
export AGENT_INSTALLER_API_SERVER_DOCKERFILE=Dockerfile.assisted-service.ocp
export OPENSHIFT_RELEASE_IMAGE=registry.ci.openshift.org/ocp/release:4.15.0-0.ci-2023-11-28-141749
pawanpinjarkar commented 9 months ago

/depends on https://github.com/openshift/assisted-service/pull/5738 and https://github.com/openshift/installer/pull/7585

bfournie commented 9 months ago

/lgtm

bfournie commented 9 months ago

Tested using latest installer with merged fix for https://github.com/openshift/installer/pull/7585 See the platform set as below and installation appears to be working.

                "platformType": "External",
                "external": {
                    "platformName": "oci"
                }
bfournie commented 9 months ago

/approve

openshift-ci[bot] commented 9 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bfournie

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift-metal3/dev-scripts/blob/master/OWNERS)~~ [bfournie] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment