openshift-metal3 / dev-scripts

Scripts to automate development/test setup for openshift integration with https://github.com/metal3-io/
Apache License 2.0
93 stars 185 forks source link

openshift-sdn support is about to be removed from the installer #1613

Closed danwinship closed 7 months ago

danwinship commented 9 months ago

openshift-sdn is now deprecated, and (most) users will no longer be able to install sdn-based clusters starting in 4.15. The installer will soon start rejecting install-configs with networkType: OpenShiftSDN. (https://github.com/openshift/installer/pull/7720). So dev-scripts needs to do one of:

  1. Switch to using NETWORK_TYPE=OVNKubernetes regardless of IP_STACK (retroactively changing the meaning of some existing configs).
  2. Switch to using NETWORK_TYPE=OVNKubernetes regardless of IP_STACK when installing 4.15 or later (causing some existing configs to silently change meaning when users move to 4.15).
  3. Start requiring NETWORK_TYPE to always be explicitly specified when IP_STACK=v4 (possibly just for 4.15+ installs) (breaking some existing configs but making it clear how to fix them, and not silently changing behavior on anyone).

I'm updating all of our IP_STACK=v4 CI jobs (even pre-4.15 ones) to explicitly set NETWORK_TYPE (https://github.com/openshift/release/pull/46286, though that's incomplete), so once that's done, it would be possible for dev-scripts to change its defaults without affecting CI.

(For CI jobs that actually need to test openshift-sdn in 4.15+, we will be hacking around the installer change by using manifests, so you don't have to worry about that. dev-scripts itself should probably not automatically hack around the installer change for users (and at any rate, the plan is for sdn to be removed from OCP entirely in 4.17, so you'll need to change something by then).