search

openshift-metal3 / dev-scripts

Scripts to automate development/test setup for openshift integration with https://github.com/metal3-io/
Apache License 2.0
93 stars 185 forks source link

Revert "METAL-759: Add nfs a backed persistent volume (#1608)" #1616

Closed derekhiggins closed 9 months ago

derekhiggins commented 9 months ago

This reverts commit b4b21a39713af2b1166ffdaf6e9da26a1c98a841.

It may have broken some dualstack setups (depending on which network was priary)

tdomnesc commented 9 months ago

/lgtm

derekhiggins commented 9 months ago

/retest-required

stbenjam commented 9 months ago

/label approved

Approving to unblock dualstack jobs, which are permafailing in periodics

openshift-ci[bot] commented 9 months ago

@stbenjam: Can not set label approved: Must be member in one of these teams: [openshift-release-oversight]

In response to [this](https://github.com/openshift-metal3/dev-scripts/pull/1616#issuecomment-1841094378): >/label approved > >Approving to unblock dualstack jobs, where are permafailing Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
stbenjam commented 9 months ago

/retest-required /skip

dtantsur commented 9 months ago

/approve

openshift-ci[bot] commented 9 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dtantsur

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift-metal3/dev-scripts/blob/master/OWNERS)~~ [dtantsur] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment