search

openshift-metal3 / dev-scripts

Scripts to automate development/test setup for openshift integration with https://github.com/metal3-io/
Apache License 2.0
93 stars 185 forks source link

MGMT-16396: Install ansible.posix collection #1619

Closed adriengentil closed 8 months ago

adriengentil commented 8 months ago

Install posix collection in order to use synchronize module. It was a built-in module before.

Remove the constraint on general collection as it was pinned because rhel 8 used a old version of ansible, which is not the case anymore with rhel 9 (https://github.com/openshift-metal3/dev-scripts/pull/1399).

openshift-ci[bot] commented 8 months ago

Hi @adriengentil. Thanks for your PR.

I'm waiting for a openshift-metal3 member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
adriengentil commented 8 months ago

/cc @derekhiggins @andfasano

dtantsur commented 8 months ago

/ok-to-test

adriengentil commented 8 months ago

/retest looks like flakes

derekhiggins commented 8 months ago

/approve

openshift-ci[bot] commented 8 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: derekhiggins

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift-metal3/dev-scripts/blob/master/OWNERS)~~ [derekhiggins] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
rccrdpccl commented 8 months ago

/lgtm

openshift-ci[bot] commented 8 months ago

@rccrdpccl: changing LGTM is restricted to collaborators

In response to [this](https://github.com/openshift-metal3/dev-scripts/pull/1619#issuecomment-1859913160): >/lgtm Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
adriengentil commented 8 months ago

/test e2e-metal-ipi-serial-ipv4

adriengentil commented 8 months ago

/test e2e-metal-ipi-serial-ipv4

andfasano commented 8 months ago

/lgtm