search

openshift-metal3 / dev-scripts

Scripts to automate development/test setup for openshift integration with https://github.com/metal3-io/
Apache License 2.0
93 stars 185 forks source link

Fix yq command to be compatible with yq v4 #1621

Open mnietoji opened 8 months ago

mnietoji commented 8 months ago

Option -y is not available in yq version 4 that is the one being installed https://github.com/openshift-metal3/dev-scripts/issues/1620

openshift-ci[bot] commented 8 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign cybertron for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/openshift-metal3/dev-scripts/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci[bot] commented 8 months ago

Hi @mnietoji. Thanks for your PR.

I'm waiting for a openshift-metal3 member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
eshulman2 commented 7 months ago

Hi @elfosardo @sadasu can you please review/comment on this patch.

sadasu commented 7 months ago

/retest

sadasu commented 7 months ago

/ok-to-test

sadasu commented 6 months ago

/retest-required

eshulman2 commented 6 months ago

/retest-required

openshift-ci[bot] commented 6 months ago

@mnietoji: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-metal-ipi-serial-ovn-ipv6 4154f48b16847ee1cd60b20d05ab559be88d2f1f link false /test e2e-metal-ipi-serial-ovn-ipv6
ci/prow/e2e-metal-ipi-ovn-dualstack 4154f48b16847ee1cd60b20d05ab559be88d2f1f link false /test e2e-metal-ipi-ovn-dualstack
ci/prow/e2e-agent-ha-dualstack 4154f48b16847ee1cd60b20d05ab559be88d2f1f link false /test e2e-agent-ha-dualstack
ci/prow/e2e-agent-sno-ipv6 4154f48b16847ee1cd60b20d05ab559be88d2f1f link false /test e2e-agent-sno-ipv6
ci/prow/e2e-metal-ipi-virtualmedia 4154f48b16847ee1cd60b20d05ab559be88d2f1f link false /test e2e-metal-ipi-virtualmedia
ci/prow/e2e-metal-ipi-bm-bond 4154f48b16847ee1cd60b20d05ab559be88d2f1f link false /test e2e-metal-ipi-bm-bond
ci/prow/e2e-metal-ipi-serial-ipv4 4154f48b16847ee1cd60b20d05ab559be88d2f1f link true /test e2e-metal-ipi-serial-ipv4
ci/prow/e2e-metal-ipi-bm 4154f48b16847ee1cd60b20d05ab559be88d2f1f link true /test e2e-metal-ipi-bm
ci/prow/e2e-metal-ipi-ovn-ipv6 4154f48b16847ee1cd60b20d05ab559be88d2f1f link true /test e2e-metal-ipi-ovn-ipv6
ci/prow/e2e-agent-compact-ipv4 4154f48b16847ee1cd60b20d05ab559be88d2f1f link true /test e2e-agent-compact-ipv4

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
elfosardo commented 2 months ago

I beleive the latest available version in pypi is still 3.x I'd rather pin yq version installed so when the new version comes out we don't break dev-scripts

elfosardo commented 1 month ago

/hold this can be closed, yq version has been pinned