search

openshift-metal3 / dev-scripts

Scripts to automate development/test setup for openshift integration with https://github.com/metal3-io/
Apache License 2.0
93 stars 185 forks source link

OCPBUGS-27189: Fix dependency issue #1625

Closed zaneb closed 8 months ago

zaneb commented 8 months ago

The create_cluster function in utils.sh relies on the function override_openshift_sdn_deprecation defined in ocp_install_env.sh. Therefore latter must be sourced anywhere that create_cluster is used, and it should not have been removed from 06_create_cluster.sh by 41443197abc8a748e192ef87e1c4c3b74c693059.

zaneb commented 8 months ago

/cc @andfasano @danwinship

rhjanders commented 8 months ago

/cc rhjanders

andfasano commented 8 months ago

/approve

openshift-ci[bot] commented 8 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andfasano

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift-metal3/dev-scripts/blob/master/OWNERS)~~ [andfasano] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
elfosardo commented 8 months ago

/lgtm