Document METAL3_DEV_ENV variable

[elfosardo]

/cc @derekhiggins @tdomnesc

[elfosardo]

/retest

[elfosardo]

/retest

[elfosardo]

the issue with e2e-metal-ipi-serial-ipv4 is independent from this change

[elfosardo]

/retest giving it another chance

[dtantsur]

/approve

[openshift-ci[bot]]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dtantsur

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift-metal3/dev-scripts/blob/master/OWNERS)~~ [dtantsur] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

[derekhiggins]

/hold I already run install requirements multiple times, when I've made local changes to metal3-dev-env, I want to get this error message, it reminds me to set METAL3_DEV_ENV (to avoid running sync_repo_and_patch)

If the error message doesn't happen my local updates would be silently zapped, without realising it I wouldn't be running the code I wanted and my changes would be lost.

[elfosardo]

@derekhiggins thanks, I think METAL3_DEV_ENV is not documented anywhere, not even in config_example.sh I'm going to convert this patch to a doc patch so we're all aware of that

[elfosardo]

@derekhiggins @dtantsur please give it another look, thanks!

[derekhiggins]

/unhold /lgtm thanks

[elfosardo]

/unhold

[derekhiggins]

/lgtm