search

openshift-metal3 / dev-scripts

Scripts to automate development/test setup for openshift integration with https://github.com/metal3-io/
Apache License 2.0
92 stars 182 forks source link

network: fix generation of VIPs for single- and dual-stack setups #1628

Open mkowalski opened 6 months ago

openshift-ci[bot] commented 6 months ago

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

openshift-ci[bot] commented 6 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign bfournie for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/openshift-metal3/dev-scripts/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
mkowalski commented 6 months ago

/cc @cybertron

cybertron commented 6 months ago

/lgtm

Seems fine. I assume this is related to deploying single stack clusters on dual stack envs?

mkowalski commented 6 months ago

/hold Until manual testing proves that all works

Yes, the issue with current state is that we do not generate a valid install-config yaml for a single-stack cluster with dual-stack hosts. For such a scenario (allowed by syntax of config.sh) we put dual-stack VIPs in install-config.yaml but only single cluster network. This is illegal and does not pass the basic validations.

With this fix I want to be explicit as the VIP configuration goes. I am still not allowing to have single VIP setup with dual-stack cluster but extending feature set is not my goal, all I want first is to remove a scenario that prevents installation when in general it should work

openshift-ci[bot] commented 6 months ago

@mkowalski: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-metal-ipi-ovn-dualstack 08803c9f491882e3c6e7b576d6a009f06ddab444 link false /test e2e-metal-ipi-ovn-dualstack
ci/prow/e2e-metal-ipi-serial-ovn-ipv6 08803c9f491882e3c6e7b576d6a009f06ddab444 link false /test e2e-metal-ipi-serial-ovn-ipv6

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).