search

openshift-metal3 / dev-scripts

Scripts to automate development/test setup for openshift integration with https://github.com/metal3-io/
Apache License 2.0
92 stars 182 forks source link

Use go 1.21 #1629

Closed honza closed 4 months ago

honza commented 5 months ago

openshift/installer now requires it; KNI_INSTALL_FROM_GIT is currently broken

openshift-ci[bot] commented 5 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign zaneb for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/openshift-metal3/dev-scripts/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci[bot] commented 5 months ago

@honza: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-agent-sno-ipv6 6186754bcebcb0af59fe9c0e6f02b1b3a34d567b link false /test e2e-agent-sno-ipv6
ci/prow/e2e-metal-ipi-serial-ipv4 6186754bcebcb0af59fe9c0e6f02b1b3a34d567b link true /test e2e-metal-ipi-serial-ipv4
ci/prow/e2e-metal-ipi-virtualmedia 6186754bcebcb0af59fe9c0e6f02b1b3a34d567b link false /test e2e-metal-ipi-virtualmedia

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
zaneb commented 4 months ago

Conflict with #1634

openshift-merge-robot commented 4 months ago

PR needs rebase.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
psathyan commented 4 months ago

You can now customize the version of GO installed via GO_VERSION in the config_<user>.sh file.

dtantsur commented 4 months ago

Superseded by https://github.com/openshift-metal3/dev-scripts/pull/1641