search

openshift-metal3 / dev-scripts

Scripts to automate development/test setup for openshift integration with https://github.com/metal3-io/
Apache License 2.0
92 stars 182 forks source link

OCPQE-19493: Update image with equinix.cloud collection #1633

Closed sgoveas closed 3 months ago

sgoveas commented 5 months ago

'facility' was deprecated from Dec 1, 2023. This PR update is to use equinix.cloud ansible collection to enable use of 'metro'.

openshift-ci[bot] commented 5 months ago

Hi @sgoveas. Thanks for your PR.

I'm waiting for a openshift-metal3 member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
derekhiggins commented 5 months ago

/lgtm

sgoveas commented 5 months ago

/retest

openshift-ci[bot] commented 5 months ago

@sgoveas: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to [this](https://github.com/openshift-metal3/dev-scripts/pull/1633#issuecomment-1953902134): >/retest Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
derekhiggins commented 5 months ago

/retest-required

derekhiggins commented 4 months ago

/approve

openshift-ci[bot] commented 4 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: derekhiggins

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift-metal3/dev-scripts/blob/master/OWNERS)~~ [derekhiggins] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
sgoveas commented 4 months ago

/retest

openshift-ci[bot] commented 4 months ago

@sgoveas: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to [this](https://github.com/openshift-metal3/dev-scripts/pull/1633#issuecomment-1991543439): >/retest Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
derekhiggins commented 4 months ago

/ok-to-test

derekhiggins commented 4 months ago

/test e2e-metal-ipi-serial-ipv4

derekhiggins commented 4 months ago

/test e2e-metal-ipi-serial-ipv4 test failed but still pending?

LiangquanLi930 commented 4 months ago

/test e2e-metal-ipi-serial-ipv4

adriengentil commented 4 months ago

/test e2e-metal-ipi-serial-ipv4

adriengentil commented 4 months ago

Our CI on assisted is broken since https://github.com/openshift/release/pull/48680 was merged. I think we need this change to be merged to fix the issue.

aleskandro commented 4 months ago

/test e2e-metal-ipi-serial-ipv4

derekhiggins commented 4 months ago

/override e2e-metal-ipi-serial-ipv4

openshift-ci[bot] commented 4 months ago

@derekhiggins: /override requires failed status contexts, check run or a prowjob name to operate on. The following unknown contexts/checkruns were given:

Only the following failed contexts/checkruns were expected:

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

In response to [this](https://github.com/openshift-metal3/dev-scripts/pull/1633#issuecomment-2012378351): >/override e2e-metal-ipi-serial-ipv4 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
derekhiggins commented 4 months ago

/override ci/prow/e2e-metal-ipi-serial-ipv4

openshift-ci[bot] commented 4 months ago

@derekhiggins: Overrode contexts on behalf of derekhiggins: ci/prow/e2e-metal-ipi-serial-ipv4

In response to [this](https://github.com/openshift-metal3/dev-scripts/pull/1633#issuecomment-2012379999): >/override ci/prow/e2e-metal-ipi-serial-ipv4 > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
derekhiggins commented 4 months ago

/hold

derekhiggins commented 4 months ago

/lgtm unhold when ever you are ready

sgoveas commented 4 months ago

/test e2e-metal-ipi-serial-ipv4

sgoveas commented 4 months ago

/test e2e-metal-ipi-serial-ipv4

sgoveas commented 4 months ago

/retest

openshift-ci[bot] commented 4 months ago

@sgoveas: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-metal-ipi-virtualmedia 23f26f79cdc0465a21e30772ab48f5d0a3f50e97 link false /test e2e-metal-ipi-virtualmedia
ci/prow/e2e-metal-ipi-bm-bond 23f26f79cdc0465a21e30772ab48f5d0a3f50e97 link false /test e2e-metal-ipi-bm-bond
ci/prow/e2e-metal-ipi-serial-ovn-ipv6 23f26f79cdc0465a21e30772ab48f5d0a3f50e97 link false /test e2e-metal-ipi-serial-ovn-ipv6

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
derekhiggins commented 3 months ago

/override ci/prow/e2e-metal-ipi-serial-ipv4

openshift-ci[bot] commented 3 months ago

@derekhiggins: Overrode contexts on behalf of derekhiggins: ci/prow/e2e-metal-ipi-serial-ipv4

In response to [this](https://github.com/openshift-metal3/dev-scripts/pull/1633#issuecomment-2032379525): >/override ci/prow/e2e-metal-ipi-serial-ipv4 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
sgoveas commented 3 months ago

/unhold