search

openshift-metal3 / dev-scripts

Scripts to automate development/test setup for openshift integration with https://github.com/metal3-io/
Apache License 2.0
92 stars 182 forks source link

MGMT-16990: Make the go version installed configurable #1634

Closed CrystalChun closed 4 months ago

CrystalChun commented 5 months ago

https://issues.redhat.com/browse/MGMT-16990 Hive has increased the minimum go version required to 1.21 which breaks the assisted-service CI jobs since the go version is pinned to 1.20.

This introduces a configurable GOVERSION variable to allow other versions to be specified and installed.

/cc @adriengentil

openshift-ci[bot] commented 5 months ago

@CrystalChun: GitHub didn't allow me to request PR reviews from the following users: adriengentil.

Note that only openshift-metal3 members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to [this](https://github.com/openshift-metal3/dev-scripts/pull/1634): >https://issues.redhat.com/browse/MGMT-16990 >Hive has increased the minimum go version required to 1.21 which breaks the assisted-service CI jobs since the go version is pinned to 1.20. > >This introduces a configurable `GOVERSION` variable to allow other versions to be specified and installed. > >/cc @adriengentil Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
openshift-ci[bot] commented 5 months ago

Hi @CrystalChun. Thanks for your PR.

I'm waiting for a openshift-metal3 member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
openshift-ci[bot] commented 5 months ago

@adriengentil: changing LGTM is restricted to collaborators

In response to [this](https://github.com/openshift-metal3/dev-scripts/pull/1634#pullrequestreview-1893774437): >/lgtm Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
CrystalChun commented 5 months ago

/cc @bfournie

dtantsur commented 5 months ago

/ok-to-test /approve

openshift-ci[bot] commented 5 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dtantsur

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift-metal3/dev-scripts/blob/master/OWNERS)~~ [dtantsur] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
CrystalChun commented 5 months ago

Tests failing on

: [sig-metal] should get working host from infra provider expand_less | 0s
-- | --
{  ofcir: Failed to create ci resource: ipi-ci-op-71cbshr5-82588-1760346696551763968}

Will retest in a few moments

CrystalChun commented 5 months ago

/retest-required

adriengentil commented 5 months ago

/retest-required

adriengentil commented 5 months ago

/test e2e-metal-ipi-ovn-ipv6 looks like flakes

adriengentil commented 5 months ago

/retest-required

adriengentil commented 5 months ago

@bfournie @dtantsur can we get a lgtm? Thanks!

elfosardo commented 5 months ago

/retest

elfosardo commented 5 months ago

/lgtm

adriengentil commented 4 months ago

/test e2e-agent-compact-ipv4

adriengentil commented 4 months ago

/test e2e-agent-compact-ipv4

adriengentil commented 4 months ago

/test e2e-agent-compact-ipv4

adriengentil commented 4 months ago

/test e2e-agent-compact-ipv4

adriengentil commented 4 months ago

/test e2e-agent-compact-ipv4

openshift-ci[bot] commented 4 months ago

@CrystalChun: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-metal-ipi-ovn-dualstack 0989cd59a5a037e2edc9b334945d1b15118be3b1 link false /test e2e-metal-ipi-ovn-dualstack
ci/prow/e2e-metal-ipi-virtualmedia 0989cd59a5a037e2edc9b334945d1b15118be3b1 link false /test e2e-metal-ipi-virtualmedia
ci/prow/e2e-metal-ipi-serial-ovn-ipv6 0989cd59a5a037e2edc9b334945d1b15118be3b1 link false /test e2e-metal-ipi-serial-ovn-ipv6

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
CrystalChun commented 4 months ago

/retest-required

psathyan commented 4 months ago

If go is already installed then GOVERSION=go1.20 is set as part of the environment variables. This would lead to failures as we are trying to reuse the same variable.

2024-03-05 08:07:34 ++(common.sh:8): eval 'GO111MODULE=""
2024-03-05 08:07:34 GOARCH="amd64"
2024-03-05 08:07:34 GOBIN=""
2024-03-05 08:07:34 GOCACHE="/home/ciuser/.cache/go-build"
2024-03-05 08:07:34 GOENV="/home/ciuser/.config/go/env"
2024-03-05 08:07:34 GOEXE=""
2024-03-05 08:07:34 GOEXPERIMENT=""
2024-03-05 08:07:34 GOFLAGS=""
2024-03-05 08:07:34 GOHOSTARCH="amd64"
2024-03-05 08:07:34 GOHOSTOS="linux"
2024-03-05 08:07:34 GOINSECURE=""
2024-03-05 08:07:34 GOMODCACHE="/home/ciuser/go/pkg/mod"
2024-03-05 08:07:34 GONOPROXY=""
2024-03-05 08:07:34 GONOSUMDB=""
2024-03-05 08:07:34 GOOS="linux"
2024-03-05 08:07:34 GOPATH="/home/ciuser/go"
2024-03-05 08:07:34 GOPRIVATE=""
2024-03-05 08:07:34 GOPROXY="https://proxy.golang.org,direct"
2024-03-05 08:07:34 GOROOT="/usr/local/go"
2024-03-05 08:07:34 GOSUMDB="sum.golang.org"
2024-03-05 08:07:34 GOTMPDIR=""
2024-03-05 08:07:34 GOTOOLDIR="/usr/local/go/pkg/tool/linux_amd64"
2024-03-05 08:07:34 GOVCS=""
2024-03-05 08:07:34 GOVERSION="go1.20"
2024-03-05 08:07:34 GCCGO="gccgo"
2024-03-05 08:07:34 GOAMD64="v1"
2024-03-05 08:07:34 AR="ar"
2024-03-05 08:07:34 CC="gcc"
2024-03-05 08:07:34 CXX="g++"
2024-03-05 08:07:34 CGO_ENABLED="1"
2024-03-05 08:07:34 GOMOD="/home/ciuser/src/github.com/openshift-metal3/dev-scripts/go.mod"
2024-03-05 08:07:34 GOWORK=""
2024-03-05 08:07:34 CGO_CFLAGS="-O2 -g"
2024-03-05 08:07:34 CGO_CPPFLAGS=""
2024-03-05 08:07:34 CGO_CXXFLAGS="-O2 -g"
2024-03-05 08:07:34 CGO_FFLAGS="-O2 -g"
2024-03-05 08:07:34 CGO_LDFLAGS="-O2 -g"
2024-03-05 08:07:34 PKG_CONFIG="pkg-config"
2024-03-05 08:07:34 GOGCCFLAGS="-fPIC -m64 -pthread -Wl,--no-gc-sections -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build1909654990=/tmp/go-build -gno-record-gcc-switches"'
psathyan commented 4 months ago

you would hit 

        "\u001b[0;31m        }\u001b[0m",                                                                                                                                                                                                                                                                                    
        "\u001b[0;31m    },\u001b[0m",                                                                                                                                                                                                                                                                                       
        "\u001b[0;31m    \"msg\": \"Request failed\",\u001b[0m",                                                                                                                                                   
        "\u001b[0;31m    \"response\": \"HTTP Error 404: Not Found\",\u001b[0m",                                                                                                                                   
        "\u001b[0;31m    \"status_code\": 404,\u001b[0m",                                                                                                                                                          
        "\u001b[0;31m    \"url\": \"https://storage.googleapis.com/golang/gogo1.19.10.linux-amd64.tar.gz\"\u001b[0m",                                                                                              
        "\u001b[0;31m}\u001b[0m",